Bug 147597

Summary: Remove UnspecifiedBoolType from JSC
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Keith Miller
Reported 2015-08-03 16:07:15 PDT
the UnspecifiedBoolType idiom we use throughout webcore is an artifact from pre C++11 when the explicit operator bool() override was added.
Attachments
Patch (3.92 KB, patch)
2015-08-04 16:22 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (3.88 KB, patch)
2015-08-05 09:10 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (4.83 KB, patch)
2015-08-05 19:43 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2015-08-04 16:22:47 PDT
Created attachment 258226 [details] Patch
Keith Miller
Comment 2 2015-08-05 09:10:16 PDT
Created attachment 258275 [details] Patch Added the overload of ! back for DFGEdge even though uses of ! on DFGEdge are not ambiguous at the moment. (I forgot about the weird effect removing ! might have with implicit conversions... stupid implicit conversions)
Keith Miller
Comment 3 2015-08-05 19:43:43 PDT
Created attachment 258340 [details] Patch Forgot to add JSRetainPtr.h
Mark Lam
Comment 4 2015-08-06 08:35:28 PDT
Comment on attachment 258340 [details] Patch r=me
Keith Miller
Comment 5 2015-08-06 08:52:18 PDT
rdar://problem/22170948
WebKit Commit Bot
Comment 6 2015-08-06 09:24:52 PDT
Comment on attachment 258340 [details] Patch Clearing flags on attachment: 258340 Committed r188040: <http://trac.webkit.org/changeset/188040>
WebKit Commit Bot
Comment 7 2015-08-06 09:24:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.