Bug 147560

Summary: Crash when signing into twitter calling WebCore::DocumentLoader::responseReceived(WebCore::CachedResource*, WebCore::ResourceResponse const&)
Product: WebKit Reporter: Brady Eidson <beidson>
Component: Page LoadingAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, japhet
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: Unspecified   
Attachments:
Description Flags
Patch v1
none
Patch v2
ap: review+
Layouttest ap: review+

Brady Eidson
Reported 2015-08-03 08:53:49 PDT
Pages loading main resource from app cache with redirects may not always be able to get a resource ldentifier This existing before, was fixed partially by http://trac.webkit.org/changeset/187466, but that fix wasn't quite good enough. Like in https://bugs.webkit.org/show_bug.cgi?id=147339, this scenario can lead to a crash. Now inside DocumentLoader::responseReceived with a similar "can't find identifier, can't find resource loader" situation. <rdar://problem/22098457>
Attachments
Patch v1 (2.24 KB, patch)
2015-08-03 08:56 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v2 (1.63 KB, patch)
2015-08-03 09:40 PDT, Brady Eidson 		ap: review+
DetailsFormatted DiffDiff
Layouttest (3.89 KB, patch)
2015-08-03 11:53 PDT, Brady Eidson 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-08-03 08:56:33 PDT
Created attachment 258063 [details] Patch v1
Brady Eidson
Comment 2 2015-08-03 09:40:48 PDT
Created attachment 258068 [details] Patch v2
Alexey Proskuryakov
Comment 3 2015-08-03 09:42:09 PDT
Comment on attachment 258068 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=258068&action=review > Source/WebCore/ChangeLog:3 > + Crash when signing into twitter calling WebCore::DocumentLoader::responseReceived(WebCore::CachedResource*, WebCore::ResourceResponse const&). Would like a regression test.
Brady Eidson
Comment 4 2015-08-03 10:07:02 PDT
(In reply to comment #3) > Comment on attachment 258068 [details] > Patch v2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=258068&action=review > > > Source/WebCore/ChangeLog:3 > > + Crash when signing into twitter calling WebCore::DocumentLoader::responseReceived(WebCore::CachedResource*, WebCore::ResourceResponse const&). > > Would like a regression test. And like with r187466, it's a struggle. But whereas with r187466 I'm not convinced it's possible, I am convinced it's possible here... so I'm working on it as a followup. https://trac.webkit.org/changeset/187740
Brady Eidson
Comment 5 2015-08-03 11:35:51 PDT
I have a test. On its way.
Brady Eidson
Comment 6 2015-08-03 11:53:05 PDT
Created attachment 258095 [details] Layouttest
Brady Eidson
Comment 7 2015-08-03 12:36:05 PDT
https://trac.webkit.org/changeset/187752
Note You need to log in before you can comment on or make changes to this bug.