Crash when signing into twitter calling WebCore::DocumentLoader::responseReceived(WebCore::CachedResource*, WebCore::ResourceResponse const&)

• Component: Page Loading
• Status: RESOLVED FIXED

[Brady Eidson]

Pages loading main resource from app cache with redirects may not always be able to get a resource ldentifier

This existing before, was fixed partially by http://trac.webkit.org/changeset/187466, but that fix wasn't quite good enough.

Like in https://bugs.webkit.org/show_bug.cgi?id=147339, this scenario can lead to a crash. Now inside DocumentLoader::responseReceived with a similar "can't find identifier, can't find resource loader" situation.

<rdar://problem/22098457>

[Brady Eidson]

Created attachment 258063 [details]
Patch v1

[Brady Eidson]

Created attachment 258068 [details]
Patch v2

[Alexey Proskuryakov]

Comment on attachment 258068 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=258068&action=review

> Source/WebCore/ChangeLog:3
> +        Crash when signing into twitter calling WebCore::DocumentLoader::responseReceived(WebCore::CachedResource*, WebCore::ResourceResponse const&).

Would like a regression test.

[Brady Eidson]

(In reply to comment #3)
> Comment on attachment 258068 [details]
> Patch v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258068&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Crash when signing into twitter calling WebCore::DocumentLoader::responseReceived(WebCore::CachedResource*, WebCore::ResourceResponse const&).
> 
> Would like a regression test.

And like with r187466, it's a struggle.  But whereas with r187466 I'm not convinced it's possible, I am convinced it's possible here...  so I'm working on it as a followup.

https://trac.webkit.org/changeset/187740

[Brady Eidson]

I have a test. On its way.

[Brady Eidson]

Created attachment 258095 [details]
Layouttest

[Brady Eidson]

https://trac.webkit.org/changeset/187752