Summary: | Fix the all-in-one build on Linux after r187659 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, commit-queue, ossy, thorton | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 102647, 147484 | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2015-08-03 04:11:27 PDT
MediaFeatureNames.cpp is included in MediaAllInOne.cpp too. How come it didn't cause build failure on Windows? But not the duplicated include causes this build failure. (In reply to comment #1) > MediaFeatureNames.cpp is included in MediaAllInOne.cpp too. > How come it didn't cause build failure on Windows? Ah, MediaAllInOne.cpp isn't included in Windows build at all. Created attachment 258053 [details]
Patch
Just a note: r187659 added all files in MediaAllInOne.cpp to CSSAllInOne.cpp, that's why we can remove MediaAllInOne.cpp instead of adding to the all-in-one build. Comment on attachment 258053 [details] Patch Clearing flags on attachment: 258053 Committed r187816: <http://trac.webkit.org/changeset/187816> All reviewed patches have been landed. Closing bug. |