Bug 147553

Summary:

Web Inspector: REGRESSION (r187708): Breakpoint dialog script action editing broken

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, hi, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Video] Broken dialog	none
[Patch] Proposed Fix	none

Description Matt Baker 2015-08-02 22:34:56 PDT

Created attachment 258049 [details]
[Video] Broken dialog

* SUMMARY
Breakpoint dialog script action editing broken. It is currently impossible to create breakpoint script actions.

* STEPS TO REPRODUCE
1. Edit breakpoint
2. Add Evaluate Script action
3. Start typing
  => Dialog jumps around on screen, focus leaves CodeMirror field while typing

* NOTES
Inspector^2 console log shows:

[Error] NotFoundError: DOM Exception 8: An attempt was made to reference a Node in a context where it does not exist. replaceWithPopover.js:282
   replaceWith Popover.js:282
   _update Popover.js:282
   update Popover.js:99
   breakpointActionViewResized Breakpoint.js:522
   _codeMirrorViewportChanged BreakpointActionView.js:199
   ...

Regressed in: http://trac.webkit.org/changeset/187708

Comment 1 Matt Baker 2015-08-03 05:05:28 PDT

Created attachment 258055 [details]
[Patch] Proposed Fix

Comment 2 Joseph Pecoraro 2015-08-03 14:03:31 PDT

Comment on attachment 258055 [details]
[Patch] Proposed Fix

Whoa, good find. r=me

Comment 3 WebKit Commit Bot 2015-08-03 15:05:49 PDT

Comment on attachment 258055 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 258055

Committed r187775: <http://trac.webkit.org/changeset/187775>

Comment 4 WebKit Commit Bot 2015-08-03 15:05:53 PDT

All reviewed patches have been landed.  Closing bug.