Summary: | Web Inspector: Unnamespaced Formatter classes break CSSStyleDeclarationTextEditor | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Baker <mattbaker> | ||||
Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | burg, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Matt Baker
2015-08-02 13:20:46 PDT
Created attachment 258039 [details]
[Patch] Proposed Fix
Comment on attachment 258039 [details]
[Patch] Proposed Fix
r=me
Comment on attachment 258039 [details] [Patch] Proposed Fix Clearing flags on attachment: 258039 Committed r187732: <http://trac.webkit.org/changeset/187732> All reviewed patches have been landed. Closing bug. Comment on attachment 258039 [details]
[Patch] Proposed Fix
I think this would break PrettyPrinting test harness:
Source/WebInspectorUI/Tools/PrettyPrinting/*
These classes were not WebInspector prefixed because they didn't rely on anything WebInspector and could be used outside of it. But it should be find to put them into the namespace.
My guess is this broke when converting classes to use block scoping. In that case the class name would likely not be exported.
(In reply to comment #5) > Comment on attachment 258039 [details] > [Patch] Proposed Fix > > I think this would break PrettyPrinting test harness: > > Source/WebInspectorUI/Tools/PrettyPrinting/* I'll file a follow up to fix it. > My guess is this broke when converting classes to use block scoping. In that > case the class name would likely not be exported. Ah, makes sense. |