Bug 147535

Summary: Inline video controls overlap each other while playing video in slideover mode
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+

Dean Jackson
Reported 2015-08-01 23:14:19 PDT
Inline video controls overlap each other while playing video in slideover mode
Attachments
Patch (3.39 KB, patch)
2015-08-01 23:17 PDT, Dean Jackson 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2015-08-01 23:17:11 PDT
<rdar://problem/22026864>
Dean Jackson
Comment 2 2015-08-01 23:17:38 PDT
Created attachment 258024 [details] Patch
Eric Carlson
Comment 3 2015-08-02 06:17:20 PDT
Comment on attachment 258024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258024&action=review Nice, the Changelog is longer than the patch > Source/WebCore/ChangeLog:22 > + (audio::-webkit-media-controls-panel .hidden): Deleted. Nit: This wasn't deleted.
Simon Fraser (smfr)
Comment 4 2015-08-02 08:45:40 PDT
Comment on attachment 258024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258024&action=review > Source/WebCore/ChangeLog:16 > + Meanwhile, now that we use the CSS zoom property for scaling, we > + don't need to factor in the page scale factor when calculating > + the size. Don't we only use zoom when scaled in one direction (page scale < 1)? Does the code consider that?
Dean Jackson
Comment 5 2015-08-02 15:55:08 PDT
Comment on attachment 258024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258024&action=review >> Source/WebCore/ChangeLog:16 >> + the size. > > Don't we only use zoom when scaled in one direction (page scale < 1)? Does the code consider that? You're right. I need to adjust for this.
Dean Jackson
Comment 6 2015-08-03 14:07:01 PDT
Committed r187762: <http://trac.webkit.org/changeset/187762>
Note You need to log in before you can comment on or make changes to this bug.