| Summary: | Inline video controls overlap each other while playing video in slideover mode | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
| Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Dean Jackson
2015-08-01 23:14:19 PDT
Created attachment 258024 [details]
Patch
Comment on attachment 258024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258024&action=review Nice, the Changelog is longer than the patch > Source/WebCore/ChangeLog:22 > + (audio::-webkit-media-controls-panel .hidden): Deleted. Nit: This wasn't deleted. Comment on attachment 258024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258024&action=review > Source/WebCore/ChangeLog:16 > + Meanwhile, now that we use the CSS zoom property for scaling, we > + don't need to factor in the page scale factor when calculating > + the size. Don't we only use zoom when scaled in one direction (page scale < 1)? Does the code consider that? Comment on attachment 258024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258024&action=review >> Source/WebCore/ChangeLog:16 >> + the size. > > Don't we only use zoom when scaled in one direction (page scale < 1)? Does the code consider that? You're right. I need to adjust for this. Committed r187762: <http://trac.webkit.org/changeset/187762> |