Bug 147526

Summary: Build with VS2015
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebKit Misc.Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mmaxfield: review+

Alex Christensen
Reported 2015-08-01 01:22:10 PDT
This completes r187702
Attachments
Patch (3.78 KB, patch)
2015-08-01 01:26 PDT, Alex Christensen 		mmaxfield: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-08-01 01:26:16 PDT
Created attachment 258006 [details] Patch
Myles C. Maxfield
Comment 2 2015-08-01 12:21:08 PDT
Comment on attachment 258006 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258006&action=review r=me > Source/WebCore/bindings/js/JSDOMBinding.h:216 > + WrapperClass* wrapper = WrapperClass::create(getDOMStructure<WrapperClass>(globalObject->vm(), globalObject), globalObject, WTF::move(ref)); just say "globalObject, Ref<DOMClass>(*node));" you may even be able to get away with removing the <DOMClass> from the line above
Alex Christensen
Comment 3 2015-08-01 12:56:25 PDT
http://trac.webkit.org/changeset/187721
Alex Christensen
Comment 4 2015-08-01 12:57:11 PDT
(In reply to comment #2) > > Source/WebCore/bindings/js/JSDOMBinding.h:216 > > + WrapperClass* wrapper = WrapperClass::create(getDOMStructure<WrapperClass>(globalObject->vm(), globalObject), globalObject, WTF::move(ref)); > > just say "globalObject, Ref<DOMClass>(*node));" > > you may even be able to get away with removing the <DOMClass> from the line > above Template parameter was necessary, WTF::move was not.
Alex Christensen
Comment 5 2015-08-01 13:15:36 PDT
Thanks for the fix, Myles. I should probably look at the code I commit :( http://trac.webkit.org/changeset/187722
Note You need to log in before you can comment on or make changes to this bug.