| Summary: | Build with VS2015 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | WebKit Misc. | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, cmarcelo, commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2015-08-01 01:22:10 PDT
Created attachment 258006 [details]
Patch
Comment on attachment 258006 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258006&action=review r=me > Source/WebCore/bindings/js/JSDOMBinding.h:216 > + WrapperClass* wrapper = WrapperClass::create(getDOMStructure<WrapperClass>(globalObject->vm(), globalObject), globalObject, WTF::move(ref)); just say "globalObject, Ref<DOMClass>(*node));" you may even be able to get away with removing the <DOMClass> from the line above (In reply to comment #2) > > Source/WebCore/bindings/js/JSDOMBinding.h:216 > > + WrapperClass* wrapper = WrapperClass::create(getDOMStructure<WrapperClass>(globalObject->vm(), globalObject), globalObject, WTF::move(ref)); > > just say "globalObject, Ref<DOMClass>(*node));" > > you may even be able to get away with removing the <DOMClass> from the line > above Template parameter was necessary, WTF::move was not. Thanks for the fix, Myles. I should probably look at the code I commit :( http://trac.webkit.org/changeset/187722 |