Bug 147504

Summary: [Cocoa] Latin quotes are used with the system font on Chinese devices
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, jonlee, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dino: review+

Myles C. Maxfield
Reported 2015-07-31 14:14:09 PDT
[Cocoa] Latin quotes are used with the system font on Chinese devices
Attachments
Patch (1.74 KB, patch)
2015-07-31 14:15 PDT, Myles C. Maxfield 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-07-31 14:15:40 PDT
Created attachment 257958 [details] Patch
Myles C. Maxfield
Comment 2 2015-07-31 14:16:09 PDT
<rdar://problem/22047626>
Myles C. Maxfield
Comment 3 2015-07-31 17:00:59 PDT
Committed r187693: <http://trac.webkit.org/changeset/187693>
Darin Adler
Comment 4 2015-08-08 14:07:24 PDT
Comment on attachment 257958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257958&action=review > Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp:45 > + if (fontData->platformData().isCompositeFontReference() || fontData->isSystemFont()) So this means that system fonts will never used our fast code path? I guess that’s OK since we don’t expect most websites to use them?
Myles C. Maxfield
Comment 5 2015-08-10 20:07:05 PDT
(In reply to comment #4) > Comment on attachment 257958 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257958&action=review > > > Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp:45 > > + if (fontData->platformData().isCompositeFontReference() || fontData->isSystemFont()) > > So this means that system fonts will never used our fast code path? I guess > that’s OK since we don’t expect most websites to use them? Yes.
Note You need to log in before you can comment on or make changes to this bug.