Summary: | Web Inspector: Unskip / Unflake inspector tests after r187627 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, burg, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | DoNotImportToRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2015-07-31 13:56:19 PDT
Created attachment 257957 [details]
[PATCH] Proposed Fix
This gets us running up to 54 of 64 tests. Each of the skipped tests has up to date bugs filed about them: * inspector/timeline/*exception* ASSERTs * inspector/debugger/*promise*uncaught* failing * inspector/replay failing Comment on attachment 257957 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=257957&action=review r=me Thanks for getting to the bottom of this. When you land this, please be around to watch the bots and update expectations if some lingering issues persist. > Source/WebInspectorUI/ChangeLog:15 > + resends the output to the new page for test output. Nice. > Source/WebInspectorUI/ChangeLog:21 > + Clearing messages wasn't really serving a purpose. Agree, it was kind of sloppy. <http://trac.webkit.org/changeset/187692> Watching the bots. I expect Windows might have some issues, in which case I'll skip all inspector tests on Windows, as I think they are all skipped on Windows in some capacity. Marked 1 test as Flakey for all, then skipped tests on Windows and GTK with: http://trac.webkit.org/changeset/187699 EFL is in a tricky spot. Most pass, some appear flakey (duplicate output), and few timeout. I'll watch it a bit. |