Bug 147499

Summary:

jsc-tailcall:Eliminate the unsafe use of regT5 in arityFixupGenerator() for X86-64 Windows

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

basile_clement

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Michael Saboff 2015-07-31 12:51:10 PDT

The fix for https://bugs.webkit.org/show_bug.cgi?id=147461 eliminated rdi as regT5 on X86-64 Windows.  rcx became the new regT5 for Windows X86-64, but that is also argumentGPR0.  The only use of regT5 is arityFixupGenerator() which also requires that regT5 doesn't collide with various register, including argumentGPR0.

Comment 1 Michael Saboff 2015-07-31 12:59:15 PDT

Created attachment 257947 [details]
Patch

Comment 2 Michael Saboff 2015-07-31 13:02:03 PDT

Committed r187670: <http://trac.webkit.org/changeset/187670>

Comment 3 Csaba Osztrogonác 2015-09-14 10:58:07 PDT

Comment on attachment 257947 [details]
Patch

Cleared review? from attachment 257947 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).