Bug 147499 - jsc-tailcall:Eliminate the unsafe use of regT5 in arityFixupGenerator() for X86-64 Windows
Summary: jsc-tailcall:Eliminate the unsafe use of regT5 in arityFixupGenerator() for X...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-31 12:51 PDT by Michael Saboff
Modified: 2015-09-14 10:58 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.98 KB, patch)
2015-07-31 12:59 PDT, Michael Saboff 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2015-07-31 12:51:10 PDT 
The fix for https://bugs.webkit.org/show_bug.cgi?id=147461 eliminated rdi as regT5 on X86-64 Windows.  rcx became the new regT5 for Windows X86-64, but that is also argumentGPR0.  The only use of regT5 is arityFixupGenerator() which also requires that regT5 doesn't collide with various register, including argumentGPR0.
Comment 1 Michael Saboff 2015-07-31 12:59:15 PDT 
Created attachment 257947 [details]
Patch
Comment 2 Michael Saboff 2015-07-31 13:02:03 PDT 
Committed r187670: <http://trac.webkit.org/changeset/187670>
Comment 3 Csaba Osztrogonác 2015-09-14 10:58:07 PDT 
Comment on attachment 257947 [details]
Patch

Cleared review? from attachment 257947 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).