Bug 147495

Summary: Rename the header file LengthBox.h to Insets.h and the classes inside accordingly
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: New BugsAssignee: Said Abou-Hallawa <sabouhallawa>
Status: NEW    
Severity: Normal CC: aj355, beidson, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch beidson: review-

Said Abou-Hallawa
Reported 2015-07-31 11:40:42 PDT
In http://trac.webkit.org/changeset/184895, LengthBox was used to replace other similar classes. The right name of the base template should be Insets and the specialized classes should be LengthInsets, LayoutInsets and FloatInsets. Unused functions (e.g. T& before(), T& after(), T& start() and T& end()) should be removed. New helper functions (e.g. T width(), T height(), void scale()) may be added.
Attachments
Patch (88.95 KB, patch)
2015-07-31 12:00 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (90.85 KB, patch)
2015-07-31 12:33 PDT, Said Abou-Hallawa 		beidson: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2015-07-31 12:00:01 PDT
Created attachment 257938 [details] Patch
WebKit Commit Bot
Comment 2 2015-07-31 12:02:40 PDT
Attachment 257938 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1794: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Said Abou-Hallawa
Comment 3 2015-07-31 12:33:05 PDT
Created attachment 257944 [details] Patch
WebKit Commit Bot
Comment 4 2015-07-31 12:37:52 PDT
Attachment 257944 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1794: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.
A J
Comment 5 2015-07-31 15:28:10 PDT
Attachment 257944 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1794: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 6 2017-04-24 19:10:59 PDT
Comment on attachment 257944 [details] Patch This patch has been pending review since 2015 with no recent activity. It seems unlikely that it would even still apply to trunk in its current form. Clearing from the review queue. Feel free to update and resubmit if the patch is still relevant.
Note You need to log in before you can comment on or make changes to this bug.