Rename the header file LengthBox.h to Insets.h and the classes inside accordingly

• Component: New Bugs
• Status: NEW ---

[Said Abou-Hallawa]

In http://trac.webkit.org/changeset/184895, LengthBox was used to replace other similar classes. The right name of the base template should be Insets and the specialized classes should be LengthInsets, LayoutInsets and FloatInsets. Unused functions (e.g. T& before(), T& after(), T& start() and T& end()) should be removed.  New helper functions (e.g. T width(), T height(), void scale()) may be added.

[Said Abou-Hallawa]

Created attachment 257938 [details]
Patch

[WebKit Commit Bot]

Attachment 257938 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1794:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Said Abou-Hallawa]

Created attachment 257944 [details]
Patch

[WebKit Commit Bot]

Attachment 257944 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1794:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 35 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[A J]

Attachment 257944 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1794:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 35 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

Comment on attachment 257944 [details]
Patch

This patch has been pending review since 2015 with no recent activity.
It seems unlikely that it would even still apply to trunk in its current form.

Clearing from the review queue.

Feel free to update and resubmit if the patch is still relevant.