Bug 147484

Summary: Use AllInOnes in CMake builds on Windows
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebKit Misc.Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=102647
Bug Depends on: 147557    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch thorton: review+

Alex Christensen
Reported 2015-07-30 23:49:23 PDT
Visual Studio cannot link more than 2GB of objects into one library. We still need the AllInOne files to get debug builds to link.
Attachments
Patch (229.37 KB, patch)
2015-07-31 00:04 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (160.66 KB, patch)
2015-07-31 10:17 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (160.74 KB, patch)
2015-07-31 10:25 PDT, Alex Christensen 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-07-31 00:04:31 PDT
Created attachment 257909 [details] Patch
Csaba Osztrogonác
Comment 2 2015-07-31 09:31:47 PDT
I'm going to push a much more simpler change to be able to use all-in-one builds on any cmake port in bug102647. I only need to do some cleanup and add a cmake option and that patch is ready for review and landing.
Alex Christensen
Comment 3 2015-07-31 10:17:04 PDT
Created attachment 257927 [details] Patch
Alex Christensen
Comment 4 2015-07-31 10:25:02 PDT
Created attachment 257928 [details] Patch
Tim Horton
Comment 5 2015-07-31 11:02:44 PDT
Comment on attachment 257928 [details] Patch rs=me
Alex Christensen
Comment 6 2015-07-31 11:07:44 PDT
http://trac.webkit.org/changeset/187659 Still waiting on bug102647
Note You need to log in before you can comment on or make changes to this bug.