| Summary: | Web Inspector: Convert DataGrid and DataGridNode classes to ES6 classes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brian Burg <burg> | ||||||
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bburg, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 142891 | ||||||||
| Attachments: |
|
||||||||
|
Description
Brian Burg
2015-07-29 22:20:57 PDT
Created attachment 257937 [details]
WIP
Created attachment 258009 [details]
PFR
Comment on attachment 258009 [details] PFR View in context: https://bugs.webkit.org/attachment.cgi?id=258009&action=review r=me > Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.js:32 > + name: { title: WebInspector.UIString("Node"), sortable: false } Style: Drop the spaces at the start and end of the object literal. > Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js:89 > - this._dataGrid = new WebInspector.DataGrid.createSortableDataGrid(columnNames, values); > + this._dataGrid = WebInspector.DataGrid.createSortableDataGrid(columnNames, values); Nice! > Source/WebInspectorUI/UserInterface/Views/LayerTreeDataGridNode.js:33 > + this.layer = layer; _layer? > Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js:37 > + columns[probe.id] = { title }; Style: Same thing, remove extra spaces. Comment on attachment 258009 [details] PFR View in context: https://bugs.webkit.org/attachment.cgi?id=258009&action=review >> Source/WebInspectorUI/UserInterface/Views/LayerTreeDataGridNode.js:33 >> + this.layer = layer; > > _layer? nm, I see this is now calling the setter and sets extra properties. Committed r187873: <http://trac.webkit.org/changeset/187873> |