Bug 147439

Summary: Web Inspector: Convert DataGrid and DataGridNode classes to ES6 classes
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 142891    
Attachments:
Description Flags
WIP
none
PFR joepeck: review+

Brian Burg
Reported 2015-07-29 22:20:57 PDT
oh god help me.
Attachments
WIP (54.68 KB, patch)
2015-07-31 11:36 PDT, Brian Burg 		no flags
DetailsFormatted DiffDiff
PFR (107.86 KB, patch)
2015-08-01 09:35 PDT, Brian Burg 		joepeck: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-07-29 22:21:08 PDT
<rdar://problem/22066417>
Brian Burg
Comment 2 2015-07-31 11:36:52 PDT
Created attachment 257937 [details] WIP
Brian Burg
Comment 3 2015-08-01 09:35:46 PDT
Created attachment 258009 [details] PFR
Joseph Pecoraro
Comment 4 2015-08-03 15:16:47 PDT
Comment on attachment 258009 [details] PFR View in context: https://bugs.webkit.org/attachment.cgi?id=258009&action=review r=me > Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.js:32 > + name: { title: WebInspector.UIString("Node"), sortable: false } Style: Drop the spaces at the start and end of the object literal. > Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js:89 > - this._dataGrid = new WebInspector.DataGrid.createSortableDataGrid(columnNames, values); > + this._dataGrid = WebInspector.DataGrid.createSortableDataGrid(columnNames, values); Nice! > Source/WebInspectorUI/UserInterface/Views/LayerTreeDataGridNode.js:33 > + this.layer = layer; _layer? > Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js:37 > + columns[probe.id] = { title }; Style: Same thing, remove extra spaces.
Joseph Pecoraro
Comment 5 2015-08-03 15:21:04 PDT
Comment on attachment 258009 [details] PFR View in context: https://bugs.webkit.org/attachment.cgi?id=258009&action=review >> Source/WebInspectorUI/UserInterface/Views/LayerTreeDataGridNode.js:33 >> + this.layer = layer; > > _layer? nm, I see this is now calling the setter and sets extra properties.
Blaze Burg
Comment 6 2015-08-04 12:10:24 PDT
Committed r187873: <http://trac.webkit.org/changeset/187873>
Note You need to log in before you can comment on or make changes to this bug.