Bug 147373

Summary:

DFG::ArgumentsEliminationPhase has a redundant check for inserting CheckInBounds when converting GetByVal to GetStack in the inline non-varargs case

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, basile_clement, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	none
the patch	none
the patch	mark.lam: review+

Description Filip Pizlo 2015-07-28 13:57:35 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2015-07-28 14:12:29 PDT

Created attachment 257681 [details]
the patch

Comment 2 Filip Pizlo 2015-07-28 14:14:27 PDT

Created attachment 257682 [details]
the patch

Comment 3 Filip Pizlo 2015-07-28 14:15:18 PDT

Created attachment 257683 [details]
the patch

Comment 4 Mark Lam 2015-07-28 14:23:22 PDT

Comment on attachment 257683 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257683&action=review

r=me

> Source/JavaScriptCore/ChangeLog:14
> +        1) Impossible to convert because. This can happen if the GetByVal is out-of-bounds of the

Remove the stray "because".

Comment 5 Filip Pizlo 2015-07-28 14:24:46 PDT

Landed in http://trac.webkit.org/changeset/187513