Bug 147368

Summary: Convert Path applier to use std::function
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
For EWS
none
Patch simon.fraser: review+, commit-queue: commit-queue-

Description Simon Fraser (smfr) 2015-07-28 13:31:14 PDT
Convert Path applier to use std::function
Comment 1 Simon Fraser (smfr) 2015-07-28 13:31:46 PDT
Created attachment 257673 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-07-28 21:37:22 PDT
Created attachment 257731 [details]
For EWS
Comment 3 Simon Fraser (smfr) 2015-07-28 22:06:59 PDT
Created attachment 257733 [details]
Patch
Comment 4 Simon Fraser (smfr) 2015-07-29 08:10:22 PDT
Comment on attachment 257733 [details]
Patch

Sam reviewed this.
Comment 5 WebKit Commit Bot 2015-07-29 08:12:02 PDT
Comment on attachment 257733 [details]
Patch

Rejecting attachment 257733 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 257733, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
Source/WebCore/rendering/svg/RenderSVGPath.cpp
patching file Source/WebCore/rendering/svg/RenderSVGShape.cpp
patching file Source/WebCore/rendering/svg/SVGMarkerData.h
patching file Source/WebCore/rendering/svg/SVGSubpathData.h
patching file Source/WebCore/svg/SVGPathUtilities.cpp
patching file Source/WebKit2/Shared/WebCoreArgumentCoders.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/6666429331931136
Comment 6 WebKit Commit Bot 2015-07-30 10:42:53 PDT
Comment on attachment 257733 [details]
Patch

Rejecting attachment 257733 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 257733, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
Source/WebCore/rendering/svg/RenderSVGPath.cpp
patching file Source/WebCore/rendering/svg/RenderSVGShape.cpp
patching file Source/WebCore/rendering/svg/SVGMarkerData.h
patching file Source/WebCore/rendering/svg/SVGSubpathData.h
patching file Source/WebCore/svg/SVGPathUtilities.cpp
patching file Source/WebKit2/Shared/WebCoreArgumentCoders.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/6414469370478592
Comment 7 Simon Fraser (smfr) 2015-07-30 12:14:24 PDT
https://trac.webkit.org/r187597