Bug 147368

Summary: Convert Path applier to use std::function
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
For EWS
none
Patch simon.fraser: review+, commit-queue: commit-queue-

Simon Fraser (smfr)
Reported 2015-07-28 13:31:14 PDT
Convert Path applier to use std::function
Attachments
Patch (21.53 KB, patch)
2015-07-28 13:31 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
For EWS (21.50 KB, patch)
2015-07-28 21:37 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (25.49 KB, patch)
2015-07-28 22:06 PDT, Simon Fraser (smfr) 		simon.fraser: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-07-28 13:31:46 PDT
Created attachment 257673 [details] Patch
Simon Fraser (smfr)
Comment 2 2015-07-28 21:37:22 PDT
Created attachment 257731 [details] For EWS
Simon Fraser (smfr)
Comment 3 2015-07-28 22:06:59 PDT
Created attachment 257733 [details] Patch
Simon Fraser (smfr)
Comment 4 2015-07-29 08:10:22 PDT
Comment on attachment 257733 [details] Patch Sam reviewed this.
WebKit Commit Bot
Comment 5 2015-07-29 08:12:02 PDT
Comment on attachment 257733 [details] Patch Rejecting attachment 257733 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 257733, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: Source/WebCore/rendering/svg/RenderSVGPath.cpp patching file Source/WebCore/rendering/svg/RenderSVGShape.cpp patching file Source/WebCore/rendering/svg/SVGMarkerData.h patching file Source/WebCore/rendering/svg/SVGSubpathData.h patching file Source/WebCore/svg/SVGPathUtilities.cpp patching file Source/WebKit2/Shared/WebCoreArgumentCoders.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/6666429331931136
WebKit Commit Bot
Comment 6 2015-07-30 10:42:53 PDT
Comment on attachment 257733 [details] Patch Rejecting attachment 257733 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 257733, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: Source/WebCore/rendering/svg/RenderSVGPath.cpp patching file Source/WebCore/rendering/svg/RenderSVGShape.cpp patching file Source/WebCore/rendering/svg/SVGMarkerData.h patching file Source/WebCore/rendering/svg/SVGSubpathData.h patching file Source/WebCore/svg/SVGPathUtilities.cpp patching file Source/WebKit2/Shared/WebCoreArgumentCoders.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/6414469370478592
Simon Fraser (smfr)
Comment 7 2015-07-30 12:14:24 PDT
https://trac.webkit.org/r187597
Note You need to log in before you can comment on or make changes to this bug.