Bug 147368 - Convert Path applier to use std::function
Summary: Convert Path applier to use std::function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-28 13:31 PDT by Simon Fraser (smfr)
Modified: 2015-07-30 12:14 PDT (History)
2 users (show)

See Also:

Attachments
Patch (21.53 KB, patch)
2015-07-28 13:31 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
For EWS (21.50 KB, patch)
2015-07-28 21:37 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (25.49 KB, patch)
2015-07-28 22:06 PDT, Simon Fraser (smfr) 		simon.fraser: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-07-28 13:31:14 PDT 
Convert Path applier to use std::function
Comment 1 Simon Fraser (smfr) 2015-07-28 13:31:46 PDT 
Created attachment 257673 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-07-28 21:37:22 PDT 
Created attachment 257731 [details]
For EWS
Comment 3 Simon Fraser (smfr) 2015-07-28 22:06:59 PDT 
Created attachment 257733 [details]
Patch
Comment 4 Simon Fraser (smfr) 2015-07-29 08:10:22 PDT 
Comment on attachment 257733 [details]
Patch

Sam reviewed this.
Comment 5 WebKit Commit Bot 2015-07-29 08:12:02 PDT 
Comment on attachment 257733 [details]
Patch

Rejecting attachment 257733 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 257733, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
Source/WebCore/rendering/svg/RenderSVGPath.cpp
patching file Source/WebCore/rendering/svg/RenderSVGShape.cpp
patching file Source/WebCore/rendering/svg/SVGMarkerData.h
patching file Source/WebCore/rendering/svg/SVGSubpathData.h
patching file Source/WebCore/svg/SVGPathUtilities.cpp
patching file Source/WebKit2/Shared/WebCoreArgumentCoders.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/6666429331931136
Comment 6 WebKit Commit Bot 2015-07-30 10:42:53 PDT 
Comment on attachment 257733 [details]
Patch

Rejecting attachment 257733 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 257733, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
Source/WebCore/rendering/svg/RenderSVGPath.cpp
patching file Source/WebCore/rendering/svg/RenderSVGShape.cpp
patching file Source/WebCore/rendering/svg/SVGMarkerData.h
patching file Source/WebCore/rendering/svg/SVGSubpathData.h
patching file Source/WebCore/svg/SVGPathUtilities.cpp
patching file Source/WebKit2/Shared/WebCoreArgumentCoders.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/6414469370478592
Comment 7 Simon Fraser (smfr) 2015-07-30 12:14:24 PDT 
https://trac.webkit.org/r187597