Bug 147364

Summary: Web Inspector: Convert NavigationItem subclasses to ES6
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Brian Burg <burg>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch timothy: review+

Description Brian Burg 2015-07-28 10:38:57 PDT 
.
Comment 1 Radar WebKit Bug Importer 2015-07-28 10:39:14 PDT 
<rdar://problem/22033042>
Comment 2 Brian Burg 2015-07-28 10:43:17 PDT 
Created attachment 257658 [details]
Patch
Comment 3 Timothy Hatcher 2015-07-28 12:19:14 PDT 
Comment on attachment 257658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257658&action=review

> Source/WebInspectorUI/UserInterface/Views/NavigationItem.js:93
>          var classNames = [WebInspector.NavigationItem.StyleClassName];

Could inline this and remove the global.

> Source/WebInspectorUI/UserInterface/Views/NavigationItem.js:103
> +WebInspector.NavigationItem.HiddenStyleClassName = "hidden";

Could be inlined in get hidden(), and use classList.toggle("hidden", flag) there.
Comment 4 Brian Burg 2015-07-28 14:52:54 PDT 
Comment on attachment 257658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257658&action=review

>> Source/WebInspectorUI/UserInterface/Views/NavigationItem.js:103
>> +WebInspector.NavigationItem.HiddenStyleClassName = "hidden";
> 
> Could be inlined in get hidden(), and use classList.toggle("hidden", flag) there.

OK, fixed this.
Comment 5 Brian Burg 2015-07-28 14:54:41 PDT 
Committed r187519: <http://trac.webkit.org/changeset/187519>