Bug 147364

Summary:

Web Inspector: Convert NavigationItem subclasses to ES6

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Brian Burg <burg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	timothy: review+

Brian Burg

Reported 2015-07-28 10:38:57 PDT

Attachments
Patch (37.52 KB, patch) 2015-07-28 10:43 PDT, Brian Burg	timothy: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-07-28 10:39:14 PDT

<rdar://problem/22033042>

Brian Burg

Comment 2 2015-07-28 10:43:17 PDT

Created attachment 257658 [details] Patch

Timothy Hatcher

Comment 3 2015-07-28 12:19:14 PDT

Comment on attachment 257658 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257658&action=review > Source/WebInspectorUI/UserInterface/Views/NavigationItem.js:93 > var classNames = [WebInspector.NavigationItem.StyleClassName]; Could inline this and remove the global. > Source/WebInspectorUI/UserInterface/Views/NavigationItem.js:103 > +WebInspector.NavigationItem.HiddenStyleClassName = "hidden"; Could be inlined in get hidden(), and use classList.toggle("hidden", flag) there.

Brian Burg

Comment 4 2015-07-28 14:52:54 PDT

Comment on attachment 257658 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257658&action=review >> Source/WebInspectorUI/UserInterface/Views/NavigationItem.js:103 >> +WebInspector.NavigationItem.HiddenStyleClassName = "hidden"; > > Could be inlined in get hidden(), and use classList.toggle("hidden", flag) there. OK, fixed this.

Brian Burg

Comment 5 2015-07-28 14:54:41 PDT

Committed r187519: <http://trac.webkit.org/changeset/187519>

Note You need to log in before you can comment on or make changes to this bug.