Bug 147363

Summary: Simplify call linking
Product: WebKit Reporter: Basile Clement <basile_clement>
Component: JavaScriptCoreAssignee: Basile Clement <basile_clement>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, keith_miller, mark.lam, mmirman, msaboff, saam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
fpizlo: review+
Benchmark results (Conf #2 is the patch) none

Basile Clement
Reported 2015-07-28 10:18:55 PDT
Currently, we are passing both a CallLinkInfo and a (CodeSpecializationKind, RegisterPreservationMode) pair to the different call linking slow paths. However, the CallLinkInfo has the CodeSpecializationKind and RegisterPreservationMode already, leading to useless boilerplate.
Attachments
Patch (46.53 KB, patch)
2015-07-28 11:05 PDT, Basile Clement 		fpizlo: review+
DetailsFormatted DiffDiff
Benchmark results (Conf #2 is the patch) (53.37 KB, text/plain)
2015-07-28 11:07 PDT, Basile Clement 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Basile Clement
Comment 1 2015-07-28 11:05:12 PDT
Created attachment 257660 [details] Patch
Basile Clement
Comment 2 2015-07-28 11:07:43 PDT
Created attachment 257662 [details] Benchmark results (Conf #2 is the patch)
Filip Pizlo
Comment 3 2015-07-28 11:08:04 PDT
Comment on attachment 257660 [details] Patch Looks great!
Basile Clement
Comment 4 2015-07-28 13:13:59 PDT
Committed r187505: <http://trac.webkit.org/changeset/187505>
Note You need to log in before you can comment on or make changes to this bug.