Bug 147337

Summary: PathApplierFunction should take a reference to a PathElement
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch dbates: review+

Description Simon Fraser (smfr) 2015-07-27 16:23:15 PDT 
PathApplierFunction should take a reference to a PathElement
Comment 1 Simon Fraser (smfr) 2015-07-27 16:24:07 PDT 
Created attachment 257610 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-07-27 18:27:34 PDT 
Created attachment 257624 [details]
Patch
Comment 3 Daniel Bates 2015-07-27 18:55:11 PDT 
Comment on attachment 257624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257624&action=review

Obviously, we need to rebase this patch before landing.

> Source/WebCore/platform/graphics/cg/PathCG.cpp:383
> +static void CGPathApplierToPathApplier(void *info, const CGPathElement* element)

We should also fix up the position of the '*' in the first argument.
Comment 4 Simon Fraser (smfr) 2015-07-28 11:23:54 PDT 
https://trac.webkit.org/r187492
Comment 5 Darin Adler 2015-07-28 11:26:51 PDT 
Comment on attachment 257624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257624&action=review

> Source/WebCore/platform/graphics/Path.h:83
> +    typedef void (*PathApplierFunction)(void* info, const PathElement&);

We should come back here and change this to be:

    typedef std::function<void (const PathElement&)> PathApplierFunction;

Cleaner to use std::function instead of void*.
Comment 6 Simon Fraser (smfr) 2015-07-28 22:07:36 PDT 
> We should come back here and change this to be:
> 
>     typedef std::function<void (const PathElement&)> PathApplierFunction;
> 
> Cleaner to use std::function instead of void*.

Doing so via bug 147368