| Summary: | Web Inspector: Object previews for SVG elements shows SVGAnimatedString instead of text | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, graouts, hi, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 258070 [details]
Testpage
Once the page is loaded and the inspector is open, click on the page to have the SVG elements logged to the console. The issue lies within the object preview payload.
Yes, the issue here is likely in InjectedScript.prototype._nodePreview in Source/JavaScriptCore/inspector/InjectedScriptSource.js. I can take a look. Created attachment 258120 [details]
[PATCH] Proposed Fix
Comment on attachment 258120 [details] [PATCH] Proposed Fix Clearing flags on attachment: 258120 Committed r187897: <http://trac.webkit.org/changeset/187897> All reviewed patches have been landed. Closing bug. |
Created attachment 257574 [details] Current Functionality I would expect that the preview of SVG elements would resolve what the classname is correctly instead of displaying [object SVGAnimatedString]. It seems to me that for the preview there should be some logic to parse the string and display the className if the animVal and baseVal match and what currently shows up otherwise.