Bug 147328

Summary: Web Inspector: Object previews for SVG elements shows SVGAnimatedString instead of text
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, hi, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Current Functionality
none
Testpage
none
[PATCH] Proposed Fix none

Devin Rousso
Reported 2015-07-27 11:30:51 PDT
Created attachment 257574 [details] Current Functionality I would expect that the preview of SVG elements would resolve what the classname is correctly instead of displaying [object SVGAnimatedString]. It seems to me that for the preview there should be some logic to parse the string and display the className if the animVal and baseVal match and what currently shows up otherwise.
Attachments
Current Functionality (67.20 KB, image/png)
2015-07-27 11:30 PDT, Devin Rousso 		no flags
Details
Testpage (366 bytes, text/html)
2015-08-03 09:58 PDT, Devin Rousso 		no flags
Details
[PATCH] Proposed Fix (5.42 KB, patch)
2015-08-03 14:58 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-07-27 11:31:11 PDT
<rdar://problem/22013846>
Devin Rousso
Comment 2 2015-08-03 09:58:55 PDT
Created attachment 258070 [details] Testpage Once the page is loaded and the inspector is open, click on the page to have the SVG elements logged to the console. The issue lies within the object preview payload.
Joseph Pecoraro
Comment 3 2015-08-03 14:06:56 PDT
Yes, the issue here is likely in InjectedScript.prototype._nodePreview in Source/JavaScriptCore/inspector/InjectedScriptSource.js. I can take a look.
Joseph Pecoraro
Comment 4 2015-08-03 14:58:26 PDT
Created attachment 258120 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 5 2015-08-04 15:40:35 PDT
Comment on attachment 258120 [details] [PATCH] Proposed Fix Clearing flags on attachment: 258120 Committed r187897: <http://trac.webkit.org/changeset/187897>
WebKit Commit Bot
Comment 6 2015-08-04 15:40:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.