Summary: | [GTK] Add API to WebKitWebsiteDataManager to handle session and local storage | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED DUPLICATE | ||||||
Severity: | Normal | Keywords: | Gtk | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 146589 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Carlos Garcia Campos
2015-07-27 04:23:21 PDT
Created attachment 257557 [details]
Patch
Comment on attachment 257557 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257557&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:824 > + origins = g_list_prepend(origins, webkitSecurityOriginCreate(origin.get())); Same question as on your other patch: I guess the same origin is guaranteed to not exist in multiple WebsiteDataRecords returned by this query? > Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:836 > + * @error: return location for error or %NULL to ignore Again, same question as on your other patch: the GError is not supposed to have any annotations? (In reply to comment #2) > Comment on attachment 257557 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257557&action=review > > > Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:824 > > + origins = g_list_prepend(origins, webkitSecurityOriginCreate(origin.get())); > > Same question as on your other patch: I guess the same origin is guaranteed > to not exist in multiple WebsiteDataRecords returned by this query? > > > Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:836 > > + * @error: return location for error or %NULL to ignore > > Again, same question as on your other patch: the GError is not supposed to > have any annotations? I think this is automatically handled by g-i, the method is marked as throws="1" in the gir file and the parameter is simply removed. Closing this, with the new approach I'm going to use a single patch. *** This bug has been marked as a duplicate of bug 146589 *** |