Bug 147318

Summary:

Web Inspector: " = $0" in Elements panel can cause a jerk by pushing nodes below it

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Animated GIF of the problem	none
Patch	none
[Animated GIF] With the patch applied	none

Nikita Vasilyev

Reported 2015-07-26 23:55:20 PDT

Created attachment 257549 [details] Animated GIF of the problem " = $0" was introduced in https://bugs.webkit.org/show_bug.cgi?id=145739. " = $0" can add an extra line. On the attached animated GIF I can't select <br> because of that. I find it incredibly annoying. "$0" shouldn't affect layout.

Attachments
Animated GIF of the problem (294.85 KB, image/gif) 2015-07-26 23:55 PDT, Nikita Vasilyev	no flags	Details
Patch (1.21 KB, patch) 2015-07-27 00:04 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
[Animated GIF] With the patch applied (123.67 KB, image/gif) 2015-07-27 00:06 PDT, Nikita Vasilyev	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-07-26 23:55:37 PDT

<rdar://problem/22005748>

Nikita Vasilyev

Comment 2 2015-07-27 00:04:21 PDT

Created attachment 257550 [details] Patch

Nikita Vasilyev

Comment 3 2015-07-27 00:06:30 PDT

Created attachment 257551 [details] [Animated GIF] With the patch applied With this patch " = $0" sometimes gets clipped, yes, but it never affects the layout.

WebKit Commit Bot

Comment 4 2015-07-27 01:20:26 PDT

Comment on attachment 257550 [details] Patch Clearing flags on attachment: 257550 Committed r187434: <http://trac.webkit.org/changeset/187434>

WebKit Commit Bot

Comment 5 2015-07-27 01:20:30 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.