Bug 147311

Summary: Rename PropertyNameMode::Both to PropertyNameMode::StringsAndSymbols
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, fpizlo, ggaren, mark.lam, oliver, saam, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+, commit-queue: commit-queue-

Yusuke Suzuki
Reported 2015-07-26 13:56:56 PDT
It makes the meaning clear in the user side (PropertyNameArray array(exec, PropertyNameMode::StringsAndSymbols).
Attachments
Patch (7.91 KB, patch)
2015-07-26 14:52 PDT, Yusuke Suzuki 		sam: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2015-07-26 14:52:13 PDT
Created attachment 257537 [details] Patch
WebKit Commit Bot
Comment 2 2015-07-27 11:44:19 PDT
Comment on attachment 257537 [details] Patch Rejecting attachment 257537 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 257537, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/ChangeLog.rej patching file Source/JavaScriptCore/bytecode/ObjectAllocationProfile.h patching file Source/JavaScriptCore/runtime/EnumerationMode.h patching file Source/JavaScriptCore/runtime/ObjectConstructor.cpp patching file Source/JavaScriptCore/runtime/ReflectObject.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Sam Weinig']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/4755451950399488
Yusuke Suzuki
Comment 3 2015-07-27 12:10:48 PDT
Oh, let's do a manual land.
Yusuke Suzuki
Comment 4 2015-07-27 12:12:11 PDT
Committed r187440: <http://trac.webkit.org/changeset/187440>
Geoffrey Garen
Comment 5 2015-07-27 15:11:49 PDT
If we ever come up with additional kinds of property names, then we should use ::All instead of ::XAndYAndZ. But I'm happy with ::XAndY for now.
Note You need to log in before you can comment on or make changes to this bug.