| Summary: | Rename PropertyNameMode::Both to PropertyNameMode::StringsAndSymbols | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, darin, fpizlo, ggaren, mark.lam, oliver, saam, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2015-07-26 13:56:56 PDT
Created attachment 257537 [details]
Patch
Comment on attachment 257537 [details] Patch Rejecting attachment 257537 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 257537, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/ChangeLog.rej patching file Source/JavaScriptCore/bytecode/ObjectAllocationProfile.h patching file Source/JavaScriptCore/runtime/EnumerationMode.h patching file Source/JavaScriptCore/runtime/ObjectConstructor.cpp patching file Source/JavaScriptCore/runtime/ReflectObject.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Sam Weinig']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/4755451950399488 Oh, let's do a manual land. Committed r187440: <http://trac.webkit.org/changeset/187440> If we ever come up with additional kinds of property names, then we should use ::All instead of ::XAndYAndZ. But I'm happy with ::XAndY for now. |