| Summary: | Expose TextIndicator-backed snapshot and rect gathering on DOMNode | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bdakin, commit-queue, enrica, mitz, sam, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2015-07-25 16:01:00 PDT
Created attachment 257520 [details]
Patch
Attachment 257520 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/objc/DOM.mm:564: The parameter name "image" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 257520 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257520&action=review > Source/WebCore/bindings/objc/DOMExtensions.h:113 > +- (void)getPreviewSnapshotImage:(CGImageRef*)cgImage andRects:(NSArray **)rects; Did you mean to add this to the Mac part of the header? This is a public header on Mac, so declarations here requires availability information and some Apple-internal process. |