Bug 147289

Summary:

[EFL] Build fix in ProtectionSpaceBase.cpp

Product:

WebKit

Reporter:

Jinwoo Song <jinwoo7.song>

Component:

WebKit Misc.

Assignee:

Jinwoo Song <jinwoo7.song>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Jinwoo Song 2015-07-24 20:45:08 PDT

In EFL port, we have following build break.

../../Source/WebCore/platform/network/ProtectionSpaceBase.cpp: In member function ‘bool WebCore::ProtectionSpaceBase::isPasswordBased() const’:
../../Source/WebCore/platform/network/ProtectionSpaceBase.cpp:118:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^
cc1plus: all warnings being treated as errors
ninja: build stopped: subcommand failed.

Comment 1 Jinwoo Song 2015-07-24 20:47:07 PDT

Created attachment 257509 [details]
Patch

Comment 2 Brent Fulgham 2015-07-24 21:41:27 PDT

Comment on attachment 257509 [details]
Patch

r=me.

Comment 3 WebKit Commit Bot 2015-07-24 22:31:15 PDT

Comment on attachment 257509 [details]
Patch

Clearing flags on attachment: 257509

Committed r187382: <http://trac.webkit.org/changeset/187382>

Comment 4 WebKit Commit Bot 2015-07-24 22:31:19 PDT

All reviewed patches have been landed.  Closing bug.