Bug 14727
| Summary: | [gdk] Move classes from WebCore/platform/gdk to WebKit/gtk/WebCoreSupport and adjust the namespace | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Holger Freyther <zecke> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | Keywords: | Gtk |
| Priority: | P2 | ||
| Version: | 523.x (Safari 3) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
| Bug Depends on: | |||
| Bug Blocks: | 14725 | ||
Holger Freyther
At least move FrameLoaderClientGdk, FrameGdk from the WebCore namespace into the WebKitGtk namespace and move these files from WebCore/platform/gdk to WebKit/gtk/WebCoreSupport.
make sure to update WebCore/WebCore.pro as well and list the files we want to move in the comments.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Roben (:aroben)
FrameGdk should not be moved, as it is a subclass of WebCore::Frame. I'd suggest FrameGdk be removed entirely (just as FrameMac/FrameWin/FrameQt were removed a few months ago).
Holger Freyther
Add the Gtk keyword, even to the curl bugs.
Holger Freyther
The first renaming is done, the next one is coming up:
WebKitGtk::FooClientGtk -> WebKit::FooClient
Holger Freyther
I think all relevant classes are in WebKit/gtk/WebCoreSupport and I don't plan to do any change to the names of these classes.