Summary: | [gtk] API design. Mapping the WebView delegates to signals. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Holger Freyther <zecke> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | alp, christian, jmalonzo | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 523.x (Safari 3) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 14725 | ||||||
Attachments: |
|
Description
Holger Freyther
2007-07-23 11:37:48 PDT
Rename the symbols from webkit_gtk to web_ and the files from webkitgtk to web (priority :fix it!!). Add the Gtk keyword, even to the curl bugs. > Rename the symbols from webkit_gtk to web_ and the files from webkitgtk to web
Please do *not* change it to web_. That would be too generic and therefore unfair against other projects. Think of web_page_new for instance. It might very easily clash with other names.
Instead my suggestion for the scheme would be either webkit_foo or gtk_webkit_foo. I tend to be in favor of gtk_webkit_foo because WebKit is a cross-platform toolkit and omitting the gtk suggests a gtk-specific toolkit imho.
*** Bug 15357 has been marked as a duplicate of this bug. *** web_ is not a popular option with the developers I've spoken with, due to namespace pollution. wk_ was also suggested but webkit_ seems to be the most sensible option. I wonder now whether the CamelCased form of this namespace should be Webkit or WebKit (ie. WebkitPage vs. WebKitPage).. Created attachment 16520 [details]
Rename the Gtk+ port API namespace
Comment on attachment 16520 [details]
Rename the Gtk+ port API namespace
If this is truly just a rename as claimed, rs=me. We should rename the files at some point as well (webkitgtkpage.cpp -> webkitpage.cpp)
|