Bug 147197

Summary: Use updated CoreAnimation snapshot SPI
Product: WebKit Reporter: James Savage <james.savage>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, commit-queue, rniwa, sam, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Bug Depends on: 147213    
Bug Blocks:    
Attachments:
Description Flags
Updated SPI
thorton: review+
Updated patch none

James Savage
Reported 2015-07-22 11:42:19 PDT
Use new CoreAnimation SPI to address snapshotting unattached layer contexts.
Attachments
Updated SPI (5.10 KB, patch)
2015-07-22 11:51 PDT, James Savage 		thorton: review+
DetailsFormatted DiffDiff
Updated patch (5.09 KB, patch)
2015-07-22 17:40 PDT, James Savage 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Savage
Comment 1 2015-07-22 11:51:09 PDT
Created attachment 257283 [details] Updated SPI
James Savage
Comment 2 2015-07-22 11:52:48 PDT
<rdar://problem/21032083>
Tim Horton
Comment 3 2015-07-22 11:53:46 PDT
Comment on attachment 257283 [details] Updated SPI View in context: https://bugs.webkit.org/attachment.cgi?id=257283&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2893 > + CARenderServerRenderDisplayLayerWithTransformAndTimeOffset(MACH_PORT_NULL, (__bridge CFStringRef)display.name, self.layer.context.contextId, reinterpret_cast<uint64_t>(self.layer), surface->surface(), 0, 0, &transform, 0); Why the __bridge? This is not an ARC file.
James Savage
Comment 4 2015-07-22 17:40:37 PDT
Created attachment 257314 [details] Updated patch Removed __bridge from typecast.
WebKit Commit Bot
Comment 5 2015-07-22 17:54:57 PDT
Comment on attachment 257314 [details] Updated patch Clearing flags on attachment: 257314 Committed r187196: <http://trac.webkit.org/changeset/187196>
WebKit Commit Bot
Comment 6 2015-07-22 17:55:01 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 7 2015-07-22 18:16:55 PDT
Re-opened since this is blocked by bug 147213
Tim Horton
Comment 8 2015-07-22 22:11:12 PDT
Relanded in http://trac.webkit.org/changeset/187215
Tim Horton
Comment 9 2015-07-22 22:33:14 PDT
http://trac.webkit.org/changeset/187216
Tim Horton
Comment 10 2015-07-23 01:00:02 PDT
http://trac.webkit.org/changeset/187219
Ryosuke Niwa
Comment 11 2015-07-24 22:39:53 PDT
iOS 8 build fix attempted in http://trac.webkit.org/changeset/187383.
Note You need to log in before you can comment on or make changes to this bug.