Summary: | Notify the UI delegate when a MediaDocument's natural size changes | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | achristensen | ||||||||||||||||
Priority: | P2 | ||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Attachments: |
|
Description
Jer Noble
2015-07-21 19:18:45 PDT
Created attachment 257238 [details]
Patch
Created attachment 257365 [details]
Patch
Created attachment 257367 [details]
Patch
Created attachment 257384 [details]
Patch
Created attachment 257392 [details]
Patch
Created attachment 257401 [details]
Patch
Created attachment 257403 [details]
Patch
Comment on attachment 257403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257403&action=review > Source/WebCore/html/HTMLMediaElement.cpp:2119 > + downcast<MediaDocument>(document()).mediaElementNaturalSizeChanged(expandedIntSize(m_player->naturalSize())); We know that m_player is non-null? Comment on attachment 257403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257403&action=review >> Source/WebCore/html/HTMLMediaElement.cpp:2119 >> + downcast<MediaDocument>(document()).mediaElementNaturalSizeChanged(expandedIntSize(m_player->naturalSize())); > > We know that m_player is non-null? This called from a callback made by the player, so it's guaranteed to be non-null. Committed r187272: <http://trac.webkit.org/changeset/187272> Fixed 32-bit build in http://trac.webkit.org/changeset/187289 |