Bug 147182

Summary: Notify the UI delegate when a MediaDocument's natural size changes
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch simon.fraser: review+

Jer Noble
Reported 2015-07-21 19:18:45 PDT
Notify the UI delegate when a MediaDocument's natural size changes
Attachments
Patch (43.89 KB, patch)
2015-07-21 19:22 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (21.22 KB, patch)
2015-07-23 12:43 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (21.23 KB, patch)
2015-07-23 12:52 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (21.35 KB, patch)
2015-07-23 14:25 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (21.25 KB, patch)
2015-07-23 15:29 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (20.97 KB, patch)
2015-07-23 15:51 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (20.92 KB, patch)
2015-07-23 16:12 PDT, Jer Noble 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2015-07-21 19:22:37 PDT
Created attachment 257238 [details] Patch
Jer Noble
Comment 2 2015-07-23 12:43:50 PDT
Created attachment 257365 [details] Patch
Jer Noble
Comment 3 2015-07-23 12:52:52 PDT
Created attachment 257367 [details] Patch
Jer Noble
Comment 4 2015-07-23 14:25:56 PDT
Created attachment 257384 [details] Patch
Jer Noble
Comment 5 2015-07-23 15:29:13 PDT
Created attachment 257392 [details] Patch
Jer Noble
Comment 6 2015-07-23 15:51:38 PDT
Created attachment 257401 [details] Patch
Jer Noble
Comment 7 2015-07-23 16:12:13 PDT
Created attachment 257403 [details] Patch
Simon Fraser (smfr)
Comment 8 2015-07-23 16:44:14 PDT
Comment on attachment 257403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257403&action=review > Source/WebCore/html/HTMLMediaElement.cpp:2119 > + downcast<MediaDocument>(document()).mediaElementNaturalSizeChanged(expandedIntSize(m_player->naturalSize())); We know that m_player is non-null?
Jer Noble
Comment 9 2015-07-23 16:46:05 PDT
Comment on attachment 257403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257403&action=review >> Source/WebCore/html/HTMLMediaElement.cpp:2119 >> + downcast<MediaDocument>(document()).mediaElementNaturalSizeChanged(expandedIntSize(m_player->naturalSize())); > > We know that m_player is non-null? This called from a callback made by the player, so it's guaranteed to be non-null.
Jer Noble
Comment 10 2015-07-23 16:48:35 PDT
Committed r187272: <http://trac.webkit.org/changeset/187272>
Alex Christensen
Comment 11 2015-07-23 22:00:42 PDT
Fixed 32-bit build in http://trac.webkit.org/changeset/187289
Note You need to log in before you can comment on or make changes to this bug.