Bug 147148

Summary: Expose shrink-wrapping as UIKit support SPI
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, enrica, rniwa, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
simon.fraser: review+, buildbot: commit-queue-
Archive of layout-test-results from ews104 for mac-mavericks-wk2 none

Tim Horton
Reported 2015-07-21 08:41:03 PDT
Expose shrink-wrapping as UIKit support SPI
Attachments
Patch (2.88 KB, patch)
2015-07-21 08:42 PDT, Tim Horton 		simon.fraser: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (574.72 KB, application/zip)
2015-07-21 09:20 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-07-21 08:42:30 PDT
Created attachment 257181 [details] Patch
Tim Horton
Comment 2 2015-07-21 08:42:53 PDT
rdar://problem/21920008
Simon Fraser (smfr)
Comment 3 2015-07-21 08:53:04 PDT
Comment on attachment 257181 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257181&action=review > Source/WebKit/ios/Misc/WebUIKitSupport.mm:183 > + [rectValue getValue:&cgRect]; Does this need to check that the object is actually an NSValue with a rect in it?
Build Bot
Comment 4 2015-07-21 09:20:53 PDT
Comment on attachment 257181 [details] Patch Attachment 257181 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5382825339518976 New failing tests: fast/dom/Window/window-property-invalid-characters-ignored.html
Build Bot
Comment 5 2015-07-21 09:20:55 PDT
Created attachment 257183 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Tim Horton
Comment 6 2015-07-21 10:15:34 PDT
http://trac.webkit.org/changeset/187107
Tim Horton
Comment 7 2015-07-21 12:34:59 PDT
http://trac.webkit.org/changeset/187113
Note You need to log in before you can comment on or make changes to this bug.