Bug 147148 - Expose shrink-wrapping as UIKit support SPI
Summary: Expose shrink-wrapping as UIKit support SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-21 08:41 PDT by Tim Horton
Modified: 2015-07-21 12:34 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.88 KB, patch)
2015-07-21 08:42 PDT, Tim Horton
simon.fraser: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (574.72 KB, application/zip)
2015-07-21 09:20 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-07-21 08:41:03 PDT
Expose shrink-wrapping as UIKit support SPI
Comment 1 Tim Horton 2015-07-21 08:42:30 PDT
Created attachment 257181 [details]
Patch
Comment 2 Tim Horton 2015-07-21 08:42:53 PDT
rdar://problem/21920008
Comment 3 Simon Fraser (smfr) 2015-07-21 08:53:04 PDT
Comment on attachment 257181 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257181&action=review

> Source/WebKit/ios/Misc/WebUIKitSupport.mm:183
> +        [rectValue getValue:&cgRect];

Does this need to check that the object is actually an NSValue with a rect in it?
Comment 4 Build Bot 2015-07-21 09:20:53 PDT
Comment on attachment 257181 [details]
Patch

Attachment 257181 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5382825339518976

New failing tests:
fast/dom/Window/window-property-invalid-characters-ignored.html
Comment 5 Build Bot 2015-07-21 09:20:55 PDT
Created attachment 257183 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 Tim Horton 2015-07-21 10:15:34 PDT
http://trac.webkit.org/changeset/187107
Comment 7 Tim Horton 2015-07-21 12:34:59 PDT
http://trac.webkit.org/changeset/187113