Bug 147141

Summary:

[Win] Add needTouchEvents() stub to WebChromeClient.h for a successful build with ENABLE_TOUCH_EVENTS=ON

Product:

WebKit

Reporter:

Sungmann Cho <sungmann.cho>

Component:

WebKit Misc.

Assignee:

Sungmann Cho <sungmann.cho>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Sungmann Cho 2015-07-20 23:21:41 PDT

Build ToT with ENABLE_TOUCH_EVENTS=ON on Windows breaks at:

WebView.cpp
..\..\win\WebView.cpp(2835): error C2259: 'WebChromeClient' : cannot instantiate abstract class
    due to following members:
    'void WebCore::ChromeClient::needTouchEvents(bool)' : is abstract
    D:\FOSS\WebKit\WebKitBuild\Debug_WinCairo\Include\WebCore/ChromeClient.h(371) : see declaration of 'WebCore::ChromeClient::needTouchEvents'

WebChromeClient needs needTouchEvents().

Comment 1 Sungmann Cho 2015-07-20 23:25:27 PDT

Created attachment 257164 [details]
Patch

Comment 2 WebKit Commit Bot 2015-07-21 16:16:02 PDT

Comment on attachment 257164 [details]
Patch

Clearing flags on attachment: 257164

Committed r187132: <http://trac.webkit.org/changeset/187132>

Comment 3 WebKit Commit Bot 2015-07-21 16:16:05 PDT

All reviewed patches have been landed.  Closing bug.