Bug 147140

Summary:

DestructuringPatternNode and DestructuringAssignmentNode should be ParserArenaFreeable

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, ggaren, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-mavericks	none
Archive of layout-test-results from ews107 for mac-mavericks-wk2	none
patch	none

Saam Barati

Reported 2015-07-20 21:23:18 PDT

And the descendants of DestructuringPatternNode that need destruction should be ParserArenaDeletable.

Attachments
patch (3.52 KB, patch) 2015-07-20 22:33 PDT, Saam Barati	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-mavericks (863.28 KB, application/zip) 2015-07-20 23:11 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (862.27 KB, application/zip) 2015-07-20 23:33 PDT, Build Bot	no flags	Details
patch (7.92 KB, patch) 2015-07-21 00:10 PDT, Saam Barati	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Saam Barati

Comment 1 2015-07-20 22:33:54 PDT

Created attachment 257161 [details] patch

Build Bot

Comment 2 2015-07-20 23:11:25 PDT

Comment on attachment 257161 [details] patch Attachment 257161 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5043540103004160 Number of test failures exceeded the failure limit.

Build Bot

Comment 3 2015-07-20 23:11:28 PDT

Created attachment 257162 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 4 2015-07-20 23:33:28 PDT

Comment on attachment 257161 [details] patch Attachment 257161 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5108245932802048 Number of test failures exceeded the failure limit.

Build Bot

Comment 5 2015-07-20 23:33:31 PDT

Created attachment 257165 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Saam Barati

Comment 6 2015-07-21 00:10:25 PDT

Created attachment 257167 [details] patch We want to make all Identifiers in the parser references to arena allocated Identifiers. BindingPatterns were not doing this.

Geoffrey Garen

Comment 7 2015-07-21 11:10:17 PDT

Comment on attachment 257167 [details] patch I think BindingNode needs to switch to const Identifier& as well.

Saam Barati

Comment 8 2015-07-21 11:23:43 PDT

Comment on attachment 257167 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=257167&action=review > Source/JavaScriptCore/parser/Nodes.h:1826 > + const Identifier& m_boundProperty; This line is BindingNode switched to "const Identifier&"

Geoffrey Garen

Comment 9 2015-07-21 11:28:43 PDT

Comment on attachment 257167 [details] patch Oops! r=me We should probably change the Identifier in ObjectPatternNode as well, just to match parsing conventions, even though it won't eliminate the destructor.

WebKit Commit Bot

Comment 10 2015-07-21 12:20:06 PDT

Comment on attachment 257167 [details] patch Clearing flags on attachment: 257167 Committed r187111: <http://trac.webkit.org/changeset/187111>

WebKit Commit Bot

Comment 11 2015-07-21 12:20:09 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.