Bug 147130

Summary: Web Inspector: console.assert(false, "Message") message is not visible in console
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: burg, commit-queue, ddkilzer, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] Before
none
[IMAGE] After
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-07-20 16:24:52 PDT
* SUMMARY console.assert(false, "Message") message is not visible in console * STEPS TO REPRODUCE 1. js> console.assert(false, "Message", 1, 2) => only says "Assertion Failed:" * NOTES Looks like there is an Array.prototype.concat that doesn't get updated
Attachments
[IMAGE] Before (36.77 KB, image/png)
2015-07-20 17:08 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] After (43.51 KB, image/png)
2015-07-20 17:08 PDT, Joseph Pecoraro 		no flags
Details
[PATCH] Proposed Fix (2.61 KB, patch)
2015-07-20 17:10 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-07-20 16:25:33 PDT
<rdar://problem/21910109>
Joseph Pecoraro
Comment 2 2015-07-20 17:08:11 PDT
Created attachment 257149 [details] [IMAGE] Before
Joseph Pecoraro
Comment 3 2015-07-20 17:08:23 PDT
Created attachment 257150 [details] [IMAGE] After
Joseph Pecoraro
Comment 4 2015-07-20 17:10:25 PDT
Created attachment 257151 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 5 2015-07-20 17:59:57 PDT
Comment on attachment 257151 [details] [PATCH] Proposed Fix Clearing flags on attachment: 257151 Committed r187052: <http://trac.webkit.org/changeset/187052>
WebKit Commit Bot
Comment 6 2015-07-20 18:00:01 PDT
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 7 2015-09-01 14:53:34 PDT
Is this issue testable?
Alexey Proskuryakov
Comment 8 2015-09-01 14:53:57 PDT
Comment on attachment 257151 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=257151&action=review > Source/WebInspectorUI/ChangeLog:4 > + Web Inspector: console.assert(false, "Message") message is not visible in console > + https://bugs.webkit.org/show_bug.cgi?id=147130 THERE ARE NO TESTS!
Timothy Hatcher
Comment 9 2015-09-01 15:12:36 PDT
We don't have UI tests in the Web Inspector. This was a change in the View object. We only test the Model and Controller objects.
Note You need to log in before you can comment on or make changes to this bug.