Bug 147130

Summary: Web Inspector: console.assert(false, "Message") message is not visible in console
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: burg, commit-queue, ddkilzer, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] Before
none
[IMAGE] After
none
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2015-07-20 16:24:52 PDT 
* SUMMARY
console.assert(false, "Message") message is not visible in console

* STEPS TO REPRODUCE
1. js> console.assert(false, "Message", 1, 2)
  => only says "Assertion Failed:"

* NOTES
Looks like there is an Array.prototype.concat that doesn't get updated
Comment 1 Radar WebKit Bug Importer 2015-07-20 16:25:33 PDT 
<rdar://problem/21910109>
Comment 2 Joseph Pecoraro 2015-07-20 17:08:11 PDT 
Created attachment 257149 [details]
[IMAGE] Before
Comment 3 Joseph Pecoraro 2015-07-20 17:08:23 PDT 
Created attachment 257150 [details]
[IMAGE] After
Comment 4 Joseph Pecoraro 2015-07-20 17:10:25 PDT 
Created attachment 257151 [details]
[PATCH] Proposed Fix
Comment 5 WebKit Commit Bot 2015-07-20 17:59:57 PDT 
Comment on attachment 257151 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 257151

Committed r187052: <http://trac.webkit.org/changeset/187052>
Comment 6 WebKit Commit Bot 2015-07-20 18:00:01 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 David Kilzer (:ddkilzer) 2015-09-01 14:53:34 PDT 
Is this issue testable?
Comment 8 Alexey Proskuryakov 2015-09-01 14:53:57 PDT 
Comment on attachment 257151 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=257151&action=review

> Source/WebInspectorUI/ChangeLog:4
> +        Web Inspector: console.assert(false, "Message") message is not visible in console
> +        https://bugs.webkit.org/show_bug.cgi?id=147130

THERE ARE NO TESTS!
Comment 9 Timothy Hatcher 2015-09-01 15:12:36 PDT 
We don't have UI tests in the Web Inspector. This was a change in the View object. We only test the Model and Controller objects.