Bug 147104

Summary:

Remove RenderTheme::shouldShowPlaceholderWhenFocused()

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, gustavo, mrobinson, rniwa

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mrobinson: review+

Description Carlos Garcia Campos 2015-07-20 02:57:04 PDT

GTK+ is the only port that returns false in shouldShowPlaceholderWhenFocused(). That's inconsistent with all other browsers that show the placeholder text even for focused entries in all platforms. We should change the GTK+ port behaviour, but that would leave all implementations of shouldShowPlaceholderWhenFocused returning true, so let's just remove it.

Comment 1 Carlos Garcia Campos 2015-07-20 02:59:43 PDT

Created attachment 257084 [details]
Patch

This makes the GTK+ port consistent with all other browsers, but inconsistent with GTK+ itself, I'll write a patch for GTK+.

Comment 2 Carlos Garcia Campos 2015-07-20 03:07:39 PDT

See https://bugzilla.gnome.org/show_bug.cgi?id=752622

Comment 3 Carlos Garcia Campos 2015-07-20 22:35:18 PDT

Committed r187095: <http://trac.webkit.org/changeset/187095>