Bug 147094

Summary:

Web Inspector: wrong cursor shown when selecting time interval from timeline overview

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Patch] Proposed Fix	none
[Patch] Proposed Fix	none

Description Brian Burg 2015-07-19 14:48:47 PDT

STEPS TO REPRODUCE:

1. Recording some stuff in a timeline
2. Mouse down in the bars area
3. Mouse move to select an interval
4. Mouse up to finish selecting

For the entirety of step 3, the cursor should change to the vertical resizer >|<. It does this correctly for the grabbers, but not when directly selecting an interval.

Comment 1 Radar WebKit Bug Importer 2015-07-19 14:48:58 PDT

<rdar://problem/21892844>

Comment 2 Matt Baker 2015-07-22 19:39:36 PDT

Created attachment 257325 [details]
[Patch] Proposed Fix

Comment 3 Timothy Hatcher 2015-07-22 20:46:28 PDT

Comment on attachment 257325 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=257325&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:718
> +            if (!this._element.classList.contains(WebInspector.TimelineRuler.CreatingSelectionStyleClassName))

You can just call add. It won't add it multiple times.

Comment 4 Matt Baker 2015-07-22 21:46:47 PDT

Created attachment 257336 [details]
[Patch] Proposed Fix

Comment 5 WebKit Commit Bot 2015-07-23 07:01:21 PDT

Comment on attachment 257336 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 257336

Committed r187227: <http://trac.webkit.org/changeset/187227>

Comment 6 WebKit Commit Bot 2015-07-23 07:01:25 PDT

All reviewed patches have been landed.  Closing bug.