Bug 147094 - Web Inspector: wrong cursor shown when selecting time interval from timeline overview
Summary: Web Inspector: wrong cursor shown when selecting time interval from timeline ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-19 14:48 PDT by Brian Burg
Modified: 2015-07-23 07:01 PDT (History)
8 users (show)

See Also:

Attachments
[Patch] Proposed Fix (5.24 KB, patch)
2015-07-22 19:39 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
[Patch] Proposed Fix (5.17 KB, patch)
2015-07-22 21:46 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2015-07-19 14:48:47 PDT 
STEPS TO REPRODUCE:

1. Recording some stuff in a timeline
2. Mouse down in the bars area
3. Mouse move to select an interval
4. Mouse up to finish selecting

For the entirety of step 3, the cursor should change to the vertical resizer >|<. It does this correctly for the grabbers, but not when directly selecting an interval.
Comment 1 Radar WebKit Bug Importer 2015-07-19 14:48:58 PDT 
<rdar://problem/21892844>
Comment 2 Matt Baker 2015-07-22 19:39:36 PDT 
Created attachment 257325 [details]
[Patch] Proposed Fix
Comment 3 Timothy Hatcher 2015-07-22 20:46:28 PDT 
Comment on attachment 257325 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=257325&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:718
> +            if (!this._element.classList.contains(WebInspector.TimelineRuler.CreatingSelectionStyleClassName))

You can just call add. It won't add it multiple times.
Comment 4 Matt Baker 2015-07-22 21:46:47 PDT 
Created attachment 257336 [details]
[Patch] Proposed Fix
Comment 5 WebKit Commit Bot 2015-07-23 07:01:21 PDT 
Comment on attachment 257336 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 257336

Committed r187227: <http://trac.webkit.org/changeset/187227>
Comment 6 WebKit Commit Bot 2015-07-23 07:01:25 PDT 
All reviewed patches have been landed.  Closing bug.