Bug 147091

Summary:

Media Session: test 'Transient Solo' interruptions

Product:

WebKit

Reporter:

Matt Rajca <mrajca>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

conrad_shultz, eric.carlson, mrajca, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

145411

Attachments:

Description	Flags
Patch	eric.carlson: review+

Description Matt Rajca 2015-07-19 11:22:15 PDT

'Transient Solo' interruptions should pause/unpause active media elements.

Comment 1 Radar WebKit Bug Importer 2015-07-19 11:22:44 PDT

<rdar://problem/21892120>

Comment 2 Matt Rajca 2015-07-19 11:24:47 PDT

Created attachment 257064 [details]
Patch

Comment 3 Eric Carlson 2015-07-27 09:23:08 PDT

Comment on attachment 257064 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257064&action=review

> LayoutTests/media/session/transient-solo-interruptions.html:14
> +            if (window.testRunner) {
> +                testRunner.dumpAsText();
> +                testRunner.waitUntilDone();
> +            }

Nit: this isn't necessary because you include video-test.js.

> LayoutTests/media/session/transient-solo-interruptions.html:16
> +            window.jsTestIsAsync = true;

Nit: this is unnecessary, it isn't used by the video testing harness.

> LayoutTests/media/session/transient-solo-interruptions.html:30
> +            document.getElementById("video").play();

Nit: there is only one <video> so you can just use "video" instead of searching for the element.

> LayoutTests/media/session/transient-solo-interruptions.html:35
> +            document.getElementById("video").onplaying = null;

Ditto.

Comment 4 Matt Rajca 2015-07-29 12:53:12 PDT

(In reply to comment #3)
> Comment on attachment 257064 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257064&action=review
> 
> > LayoutTests/media/session/transient-solo-interruptions.html:14
> > +            if (window.testRunner) {
> > +                testRunner.dumpAsText();
> > +                testRunner.waitUntilDone();
> > +            }
> 
> Nit: this isn't necessary because you include video-test.js.

Removed.

> 
> > LayoutTests/media/session/transient-solo-interruptions.html:16
> > +            window.jsTestIsAsync = true;
> 
> Nit: this is unnecessary, it isn't used by the video testing harness.

Removed.

> 
> > LayoutTests/media/session/transient-solo-interruptions.html:30
> > +            document.getElementById("video").play();
> 
> Nit: there is only one <video> so you can just use "video" instead of
> searching for the element.

Changed.

> 
> > LayoutTests/media/session/transient-solo-interruptions.html:35
> > +            document.getElementById("video").onplaying = null;
> 
> Ditto.

Comment 5 Matt Rajca 2015-07-29 12:56:52 PDT

Committed r187552: <http://trac.webkit.org/changeset/187552>