| Summary: | MiniBrowser window title is just "Window" when page has no <title> | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, mitz, sam, simon.fraser, thorton | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2015-07-18 17:52:48 PDT
Created attachment 257038 [details]
Patch
Comment on attachment 257038 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257038&action=review > Tools/MiniBrowser/mac/WK1BrowserWindowController.m:309 > + title = url.lastPathComponent; I'm assuming this was written for file:// URLs? It's going to look pretty silly on the web. > Tools/MiniBrowser/mac/WK1BrowserWindowController.m:312 > + [self.window setTitle:[title stringByAppendingString:@" [WK1]"]]; Dots? (In reply to comment #2) > Comment on attachment 257038 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257038&action=review > > > Tools/MiniBrowser/mac/WK1BrowserWindowController.m:309 > > + title = url.lastPathComponent; > > I'm assuming this was written for file:// URLs? It's going to look pretty > silly on the web. Don't care! Comment on attachment 257038 [details] Patch Clearing flags on attachment: 257038 Committed r187007: <http://trac.webkit.org/changeset/187007> All reviewed patches have been landed. Closing bug. Comment on attachment 257038 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257038&action=review > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:527 > + [self updateTitle:nil]; Is this needed? It sounds like a bug if it is. |