RESOLVED FIXED 147076
MiniBrowser window title is just "Window" when page has no <title> 
https://bugs.webkit.org/show_bug.cgi?id=147076
Summary MiniBrowser window title is just "Window" when page has no <title>
Simon Fraser (smfr)
Reported 2015-07-18 17:52:48 PDT
MiniBrowser window title is just "Window" when page has no <title>
Attachments
Patch (4.38 KB, patch)
2015-07-18 17:53 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-07-18 17:53:43 PDT
Created attachment 257038 [details] Patch
Tim Horton
Comment 2 2015-07-18 18:43:33 PDT
Comment on attachment 257038 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257038&action=review > Tools/MiniBrowser/mac/WK1BrowserWindowController.m:309 > + title = url.lastPathComponent; I'm assuming this was written for file:// URLs? It's going to look pretty silly on the web. > Tools/MiniBrowser/mac/WK1BrowserWindowController.m:312 > + [self.window setTitle:[title stringByAppendingString:@" [WK1]"]]; Dots?
Simon Fraser (smfr)
Comment 3 2015-07-18 19:12:28 PDT
(In reply to comment #2) > Comment on attachment 257038 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257038&action=review > > > Tools/MiniBrowser/mac/WK1BrowserWindowController.m:309 > > + title = url.lastPathComponent; > > I'm assuming this was written for file:// URLs? It's going to look pretty > silly on the web. Don't care!
WebKit Commit Bot
Comment 4 2015-07-18 20:39:03 PDT
Comment on attachment 257038 [details] Patch Clearing flags on attachment: 257038 Committed r187007: <http://trac.webkit.org/changeset/187007>
WebKit Commit Bot
Comment 5 2015-07-18 20:39:08 PDT
All reviewed patches have been landed. Closing bug.
mitz
Comment 6 2015-07-18 20:46:27 PDT
Comment on attachment 257038 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257038&action=review > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:527 > + [self updateTitle:nil]; Is this needed? It sounds like a bug if it is.
Note You need to log in before you can comment on or make changes to this bug.