Bug 147076 - MiniBrowser window title is just "Window" when page has no <title>
Summary: MiniBrowser window title is just "Window" when page has no <title>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-18 17:52 PDT by Simon Fraser (smfr)
Modified: 2015-07-18 20:46 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.38 KB, patch)
2015-07-18 17:53 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-07-18 17:52:48 PDT 
MiniBrowser window title is just "Window" when page has no <title>
Comment 1 Simon Fraser (smfr) 2015-07-18 17:53:43 PDT 
Created attachment 257038 [details]
Patch
Comment 2 Tim Horton 2015-07-18 18:43:33 PDT 
Comment on attachment 257038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257038&action=review

> Tools/MiniBrowser/mac/WK1BrowserWindowController.m:309
> +        title = url.lastPathComponent;

I'm assuming this was written for file:// URLs? It's going to look pretty silly on the web.

> Tools/MiniBrowser/mac/WK1BrowserWindowController.m:312
> +    [self.window setTitle:[title stringByAppendingString:@" [WK1]"]];

Dots?
Comment 3 Simon Fraser (smfr) 2015-07-18 19:12:28 PDT 
(In reply to comment #2)
> Comment on attachment 257038 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257038&action=review
> 
> > Tools/MiniBrowser/mac/WK1BrowserWindowController.m:309
> > +        title = url.lastPathComponent;
> 
> I'm assuming this was written for file:// URLs? It's going to look pretty
> silly on the web.

Don't care!
Comment 4 WebKit Commit Bot 2015-07-18 20:39:03 PDT 
Comment on attachment 257038 [details]
Patch

Clearing flags on attachment: 257038

Committed r187007: <http://trac.webkit.org/changeset/187007>
Comment 5 WebKit Commit Bot 2015-07-18 20:39:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 mitz 2015-07-18 20:46:27 PDT 
Comment on attachment 257038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257038&action=review

> Tools/MiniBrowser/mac/WK2BrowserWindowController.m:527
> +    [self updateTitle:nil];

Is this needed? It sounds like a bug if it is.