Bug 147058

Summary: [iOS] TextIndicator has a large forehead when line-height > 1
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, enrica, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dino: review+

Description Tim Horton 2015-07-17 16:51:43 PDT
[iOS] TextIndicator has a large forehead when line-height > 1
Comment 1 Tim Horton 2015-07-17 16:53:34 PDT
Created attachment 257004 [details]
Patch
Comment 2 Dean Jackson 2015-07-17 17:09:00 PDT
Comment on attachment 257004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257004&action=review

> Source/WebKit2/ChangeLog:11
> +        Apply a review comment that I left myself and then forgot about.

Huh? A review comment from another fix?
Comment 3 Tim Horton 2015-07-17 17:20:50 PDT
(In reply to comment #2)
> Comment on attachment 257004 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257004&action=review
> 
> > Source/WebKit2/ChangeLog:11
> > +        Apply a review comment that I left myself and then forgot about.
> 
> Huh? A review comment from another fix?

Yes. But still related to this! (and the original version of this patch actually depended on that review comment having been applied, so I've just kept it around).
Comment 4 Tim Horton 2015-07-17 17:22:32 PDT
http://trac.webkit.org/changeset/186978