Bug 147058

Summary:

[iOS] TextIndicator has a large forehead when line-height > 1

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, enrica, sam, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	dino: review+

Tim Horton

Reported 2015-07-17 16:51:43 PDT

[iOS] TextIndicator has a large forehead when line-height > 1

Attachments
Patch (7.24 KB, patch) 2015-07-17 16:53 PDT, Tim Horton	dino: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2015-07-17 16:53:34 PDT

Created attachment 257004 [details] Patch

Dean Jackson

Comment 2 2015-07-17 17:09:00 PDT

Comment on attachment 257004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257004&action=review > Source/WebKit2/ChangeLog:11 > + Apply a review comment that I left myself and then forgot about. Huh? A review comment from another fix?

Tim Horton

Comment 3 2015-07-17 17:20:50 PDT

(In reply to comment #2) > Comment on attachment 257004 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257004&action=review > > > Source/WebKit2/ChangeLog:11 > > + Apply a review comment that I left myself and then forgot about. > > Huh? A review comment from another fix? Yes. But still related to this! (and the original version of this patch actually depended on that review comment having been applied, so I've just kept it around).

Tim Horton

Comment 4 2015-07-17 17:22:32 PDT

http://trac.webkit.org/changeset/186978

Note You need to log in before you can comment on or make changes to this bug.