| Summary: | Video posters disappear once media has loaded | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | dino, eric.carlson, jeremyj-wk, jer.noble, jonlee, simon.fraser, thorton, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Myles C. Maxfield
2015-07-17 13:22:40 PDT
Created attachment 256982 [details]
Patch
Comment on attachment 256982 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256982&action=review r+ on the code change, but the test needs tweaking. > LayoutTests/compositing/video/poster.html:13 > +<p>This test makes sure that video posters are displayed even after the source is loaded</p> > +<video id="v" src="../resources/video.mp4" poster="../resources/simple_image.png"></video> Doesn't this bug only reproduce if controls are shown, or the video is composited for other reasons? You should use the scripts used by media tests to load the video, too. Comment on attachment 256982 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256982&action=review >> LayoutTests/compositing/video/poster.html:13 >> +<video id="v" src="../resources/video.mp4" poster="../resources/simple_image.png"></video> > > Doesn't this bug only reproduce if controls are shown, or the video is composited for other reasons? > > You should use the scripts used by media tests to load the video, too. Yes, please include media-file.js and use findMediaFile. Created attachment 256990 [details]
Patch
Created attachment 256997 [details]
Patch
Committed r186968: <http://trac.webkit.org/changeset/186968> |