Bug 147045

Summary: Video posters disappear once media has loaded
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, eric.carlson, jeremyj-wk, jer.noble, jonlee, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch simon.fraser: review+

Myles C. Maxfield
Reported 2015-07-17 13:22:40 PDT
Video posters disappear once media has loaded
Attachments
Patch (3.85 KB, patch)
2015-07-17 13:26 PDT, Myles C. Maxfield
no flags
Patch (4.32 KB, patch)
2015-07-17 14:37 PDT, Myles C. Maxfield
no flags
Patch (4.39 KB, patch)
2015-07-17 15:16 PDT, Myles C. Maxfield
simon.fraser: review+
Myles C. Maxfield
Comment 1 2015-07-17 13:26:04 PDT
Myles C. Maxfield
Comment 2 2015-07-17 13:32:41 PDT
Simon Fraser (smfr)
Comment 3 2015-07-17 13:37:24 PDT
Comment on attachment 256982 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256982&action=review r+ on the code change, but the test needs tweaking. > LayoutTests/compositing/video/poster.html:13 > +<p>This test makes sure that video posters are displayed even after the source is loaded</p> > +<video id="v" src="../resources/video.mp4" poster="../resources/simple_image.png"></video> Doesn't this bug only reproduce if controls are shown, or the video is composited for other reasons? You should use the scripts used by media tests to load the video, too.
Eric Carlson
Comment 4 2015-07-17 13:55:24 PDT
Comment on attachment 256982 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256982&action=review >> LayoutTests/compositing/video/poster.html:13 >> +<video id="v" src="../resources/video.mp4" poster="../resources/simple_image.png"></video> > > Doesn't this bug only reproduce if controls are shown, or the video is composited for other reasons? > > You should use the scripts used by media tests to load the video, too. Yes, please include media-file.js and use findMediaFile.
Myles C. Maxfield
Comment 5 2015-07-17 14:37:42 PDT
Myles C. Maxfield
Comment 6 2015-07-17 15:16:15 PDT
Myles C. Maxfield
Comment 7 2015-07-17 16:02:25 PDT
Note You need to log in before you can comment on or make changes to this bug.