Bug 147042

Summary:

Media Session: Add support for 'Content' interruption types

Product:

WebKit

Reporter:

Matt Rajca <mrajca>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, conrad_shultz, eric.carlson, jer.noble, mrajca, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

145411

Attachments:

Description	Flags
Patch	none
Patch	eric.carlson: review+, buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-mavericks	none
Archive of layout-test-results from ews104 for mac-mavericks-wk2	none

Matt Rajca

Reported 2015-07-17 10:29:04 PDT

When a start-of-interruption notification comes in with a 'Content' interruption type, all media elements should be paused indefinitely.

Attachments
Patch (4.26 KB, patch) 2015-07-17 10:34 PDT, Matt Rajca	no flags	Details Formatted Diff Diff
Patch (7.14 KB, patch) 2015-07-17 17:33 PDT, Matt Rajca	eric.carlson: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-mavericks (596.90 KB, application/zip) 2015-07-17 20:42 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (595.22 KB, application/zip) 2015-07-17 21:41 PDT, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-07-17 10:30:03 PDT

<rdar://problem/21876104>

Matt Rajca

Comment 2 2015-07-17 10:34:47 PDT

Created attachment 256976 [details] Patch

Eric Carlson

Comment 3 2015-07-17 14:08:25 PDT

(In reply to comment #2) > Created attachment 256976 [details] > Patch Please include a test with this change.

Matt Rajca

Comment 4 2015-07-17 17:33:28 PDT

Created attachment 257009 [details] Patch

Matt Rajca

Comment 5 2015-07-17 17:35:24 PDT

(In reply to comment #3) > (In reply to comment #2) > > Created attachment 256976 [details] > > Patch > > Please include a test with this change. Added. It depends on Bug 147060.

Eric Carlson

Comment 6 2015-07-17 19:59:34 PDT

Comment on attachment 257009 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257009&action=review > LayoutTests/media/session/content-interruptions.html:52 > + <video id="video" src="../content/counting.mp4" /> Please include media-file.js and use src=findMediaFile("../content/counting") so this will work on platforms that don't support MPEG-4.

Build Bot

Comment 7 2015-07-17 20:42:32 PDT

Comment on attachment 257009 [details] Patch Attachment 257009 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4621183756533760 New failing tests: media/session/content-interruptions.html

Build Bot

Comment 8 2015-07-17 20:42:36 PDT

Created attachment 257022 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 9 2015-07-17 21:41:54 PDT

Comment on attachment 257009 [details] Patch Attachment 257009 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6226449258250240 New failing tests: media/session/content-interruptions.html

Build Bot

Comment 10 2015-07-17 21:41:59 PDT

Created attachment 257023 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Matt Rajca

Comment 11 2015-07-18 19:15:15 PDT

(In reply to comment #6) > Comment on attachment 257009 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257009&action=review > > > LayoutTests/media/session/content-interruptions.html:52 > > + <video id="video" src="../content/counting.mp4" /> > > Please include media-file.js and use > src=findMediaFile("../content/counting") so this will work on platforms that > don't support MPEG-4. Fixed.

Matt Rajca

Comment 12 2015-07-18 19:15:48 PDT

(In reply to comment #7) > Comment on attachment 257009 [details] > Patch > > Attachment 257009 [details] did not pass mac-ews (mac): > Output: http://webkit-queues.appspot.com/results/4621183756533760 > > New failing tests: > media/session/content-interruptions.html Forgot to update TestExpectations.

Matt Rajca

Comment 13 2015-07-18 19:16:22 PDT

Committed r187006: <http://trac.webkit.org/changeset/187006>

Note You need to log in before you can comment on or make changes to this bug.