Bug 147042

Summary:

Media Session: Add support for 'Content' interruption types

Product:

WebKit

Reporter:

Matt Rajca <mrajca>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, conrad_shultz, eric.carlson, jer.noble, mrajca, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

145411

Attachments:

Description	Flags
Patch	none
Patch	eric.carlson: review+, buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-mavericks	none
Archive of layout-test-results from ews104 for mac-mavericks-wk2	none

Description Matt Rajca 2015-07-17 10:29:04 PDT

When a start-of-interruption notification comes in with a 'Content' interruption type, all media elements should be paused indefinitely.

Comment 1 Radar WebKit Bug Importer 2015-07-17 10:30:03 PDT

<rdar://problem/21876104>

Comment 2 Matt Rajca 2015-07-17 10:34:47 PDT

Created attachment 256976 [details]
Patch

Comment 3 Eric Carlson 2015-07-17 14:08:25 PDT

(In reply to comment #2)
> Created attachment 256976 [details]
> Patch

Please include a test with this change.

Comment 4 Matt Rajca 2015-07-17 17:33:28 PDT

Created attachment 257009 [details]
Patch

Comment 5 Matt Rajca 2015-07-17 17:35:24 PDT

(In reply to comment #3)
> (In reply to comment #2)
> > Created attachment 256976 [details]
> > Patch
> 
> Please include a test with this change.

Added. It depends on Bug 147060.

Comment 6 Eric Carlson 2015-07-17 19:59:34 PDT

Comment on attachment 257009 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257009&action=review

> LayoutTests/media/session/content-interruptions.html:52
> +    <video id="video" src="../content/counting.mp4" />

Please include media-file.js and use src=findMediaFile("../content/counting") so this will work on platforms that don't support MPEG-4.

Comment 7 Build Bot 2015-07-17 20:42:32 PDT

Comment on attachment 257009 [details]
Patch

Attachment 257009 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4621183756533760

New failing tests:
media/session/content-interruptions.html

Comment 8 Build Bot 2015-07-17 20:42:36 PDT

Created attachment 257022 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

Comment 9 Build Bot 2015-07-17 21:41:54 PDT

Comment on attachment 257009 [details]
Patch

Attachment 257009 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6226449258250240

New failing tests:
media/session/content-interruptions.html

Comment 10 Build Bot 2015-07-17 21:41:59 PDT

Created attachment 257023 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

Comment 11 Matt Rajca 2015-07-18 19:15:15 PDT

(In reply to comment #6)
> Comment on attachment 257009 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257009&action=review
> 
> > LayoutTests/media/session/content-interruptions.html:52
> > +    <video id="video" src="../content/counting.mp4" />
> 
> Please include media-file.js and use
> src=findMediaFile("../content/counting") so this will work on platforms that
> don't support MPEG-4.

Fixed.

Comment 12 Matt Rajca 2015-07-18 19:15:48 PDT

(In reply to comment #7)
> Comment on attachment 257009 [details]
> Patch
> 
> Attachment 257009 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.appspot.com/results/4621183756533760
> 
> New failing tests:
> media/session/content-interruptions.html

Forgot to update TestExpectations.

Comment 13 Matt Rajca 2015-07-18 19:16:22 PDT

Committed r187006: <http://trac.webkit.org/changeset/187006>