| Summary: | Improve rect shrink-wrapping algorithm | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, commit-queue, enrica, sam, simon.fraser | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Tim Horton
2015-07-17 05:17:37 PDT
Created attachment 256967 [details]
Patch
This is probably best read as a side-by-side diff or something because it's basically a rewrite of the whole file and the unified diff is completely useless. Created attachment 256993 [details]
Patch
Attachment 256993 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:270: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 256993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256993&action=review > Source/WebCore/platform/graphics/PathUtilities.cpp:42 > + class Node : public FloatPoint { I think this should be a "has a" FloatPoint, not "Is a" FloatPoint |