Summary: | Add shrink-wrapped link highlights | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, enrica, sam, simon.fraser, thorton | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tim Horton
2015-07-16 15:10:59 PDT
Created attachment 256931 [details]
Patch
Comment on attachment 256931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256931&action=review > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2201 > + RefPtr<TextIndicator> textIndicator = TextIndicator::createWithRange(*linkRange, TextIndicatorPresentationTransition::FadeIn, marginInPoints * deviceScaleFactor); This should use TextIndicatorPresentationTransition::None (but it doesn't really matter as long as we don't use one that requires a contentImageWithHighlight). Comment on attachment 256931 [details]
Patch
Looks good to me.
|