Bug 147021

Summary: Add shrink-wrapped link highlights
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, enrica, sam, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch enrica: review+

Tim Horton
Reported 2015-07-16 15:10:59 PDT
Add shrink-wrapped link highlights
Attachments
Patch (18.84 KB, patch)
2015-07-16 15:12 PDT, Tim Horton 		enrica: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-07-16 15:12:39 PDT
Created attachment 256931 [details] Patch
Tim Horton
Comment 2 2015-07-16 15:29:40 PDT
Comment on attachment 256931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256931&action=review > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2201 > + RefPtr<TextIndicator> textIndicator = TextIndicator::createWithRange(*linkRange, TextIndicatorPresentationTransition::FadeIn, marginInPoints * deviceScaleFactor); This should use TextIndicatorPresentationTransition::None (but it doesn't really matter as long as we don't use one that requires a contentImageWithHighlight).
Enrica Casucci
Comment 3 2015-07-16 15:58:08 PDT
Comment on attachment 256931 [details] Patch Looks good to me.
Tim Horton
Comment 4 2015-07-16 16:16:46 PDT
https://trac.webkit.org/changeset/186916
Note You need to log in before you can comment on or make changes to this bug.