Bug 147021 - Add shrink-wrapped link highlights
Summary: Add shrink-wrapped link highlights
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-16 15:10 PDT by Tim Horton
Modified: 2015-07-16 16:16 PDT (History)
5 users (show)

See Also:


Attachments
Patch (18.84 KB, patch)
2015-07-16 15:12 PDT, Tim Horton
enrica: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-07-16 15:10:59 PDT
Add shrink-wrapped link highlights
Comment 1 Tim Horton 2015-07-16 15:12:39 PDT
Created attachment 256931 [details]
Patch
Comment 2 Tim Horton 2015-07-16 15:29:40 PDT
Comment on attachment 256931 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256931&action=review

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2201
> +                        RefPtr<TextIndicator> textIndicator = TextIndicator::createWithRange(*linkRange, TextIndicatorPresentationTransition::FadeIn, marginInPoints * deviceScaleFactor);

This should use TextIndicatorPresentationTransition::None (but it doesn't really matter as long as we don't use one that requires a contentImageWithHighlight).
Comment 3 Enrica Casucci 2015-07-16 15:58:08 PDT
Comment on attachment 256931 [details]
Patch

Looks good to me.
Comment 4 Tim Horton 2015-07-16 16:16:46 PDT
https://trac.webkit.org/changeset/186916