Bug 147015

Summary: WebsiteDataStore operations need to grab background assertions
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Description Anders Carlsson 2015-07-16 14:12:13 PDT
WebsiteDataStore operations need to grab background assertions
Comment 1 Anders Carlsson 2015-07-16 14:12:43 PDT
Created attachment 256924 [details]
Patch
Comment 2 mitz 2015-07-16 14:34:23 PDT
Comment on attachment 256924 [details]
Patch

We normally have the callers create the callbacks using the create function that takes an activity token. That’s why we added that parameter. Can you follow that established pattern in this case?
Comment 3 mitz 2015-07-16 14:39:25 PDT
(In reply to comment #2)
> Comment on attachment 256924 [details]
> Patch
> 
> We normally have the callers create the callbacks using the create function
> that takes an activity token. That’s why we added that parameter. Can you
> follow that established pattern in this case?

I forgot to mention that we normally do this using CallbackMap.
Comment 4 Anders Carlsson 2015-07-17 10:34:20 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 256924 [details]
> > Patch
> > 
> > We normally have the callers create the callbacks using the create function
> > that takes an activity token. That’s why we added that parameter. Can you
> > follow that established pattern in this case?
> 
> I forgot to mention that we normally do this using CallbackMap.

I'm not going to make such an invasive change at this point.
Comment 5 Sam Weinig 2015-07-17 14:06:35 PDT
Comment on attachment 256924 [details]
Patch

Seems worth adding FIXMEs about using CallbackMap in the future.
Comment 6 Anders Carlsson 2015-07-20 10:09:28 PDT
Committed r187023: <http://trac.webkit.org/changeset/187023>
Comment 7 Anders Carlsson 2015-07-20 10:10:49 PDT
(In reply to comment #5)
> Comment on attachment 256924 [details]
> Patch
> 
> Seems worth adding FIXMEs about using CallbackMap in the future.

The ability to do async messages with replies should be built into IPC::Connection, not layered on top of it.