Bug 146994

Summary: [Mac] Web Inspector toolbar can be covered by the Safari tab bar when docked to the right
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: WebKit2Assignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, joepeck, thorton, timothy, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[Image] Covered toolbar
none
[Patch] Proposed Fix none

Matt Baker
Reported 2015-07-15 18:47:34 PDT
* SUMMARY Web Inspector toolbar can be covered by the Safari tab bar when docked to the right. * STEPS TO REPRODUCE 1. Open Safari, dock Inspector on right. 2. Create a new tab. 3. Switch back to tab containing the docked Inspector. 4. Close second tab. 5. Repeat steps 2 & 3. => Safari switches back to first tab, and Inspector toolbar is covered by tab bar.
Attachments
[Image] Covered toolbar (402.67 KB, image/png)
2015-07-15 18:48 PDT, Matt Baker 		no flags
Details
[Patch] Proposed Fix (2.74 KB, patch)
2015-07-15 19:11 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2015-07-15 18:48:42 PDT
Created attachment 256886 [details] [Image] Covered toolbar
Matt Baker
Comment 2 2015-07-15 18:49:54 PDT
<rdar://problem/21669802>
Matt Baker
Comment 3 2015-07-15 19:11:40 PDT
Created attachment 256887 [details] [Patch] Proposed Fix
Joseph Pecoraro
Comment 4 2015-07-16 11:58:51 PDT
Comment on attachment 256887 [details] [Patch] Proposed Fix Looks good to me. I tested briefly and didn't see any issues after removing this code. I cannot remember why this was added, I wonder if it was just performance. Needs a WK2 Owner nod.
Brian Burg
Comment 5 2015-07-16 16:16:40 PDT
Comment on attachment 256887 [details] [Patch] Proposed Fix That code was added in the change to have a separate inspector process, to avoid recursively triggering -(void)inspectedViewFrameDidChange when adjusting docked size. It might have been made unnecessary with the switch to WKWebView, since the current code tries to only listen for viewFrameDidChange of the single active parent frame.
WebKit Commit Bot
Comment 6 2015-07-16 20:56:32 PDT
Comment on attachment 256887 [details] [Patch] Proposed Fix Clearing flags on attachment: 256887 Committed r186924: <http://trac.webkit.org/changeset/186924>
WebKit Commit Bot
Comment 7 2015-07-16 20:56:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.