| Summary: | Move indicator rect uniting code to TextIndicatorWindow instead of TextIndicator | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, commit-queue, dbates, sam, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2015-07-15 18:08:19 PDT
Created attachment 256882 [details]
Patch
Comment on attachment 256882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256882&action=review > Source/WebCore/page/TextIndicator.cpp:-52 > -const float dropShadowBlurRadius = 12; Notice that the !ENABLE(LEGACY_TEXT_INDICATOR_STYLE)-variant of the constant dropShadowBlurRadius is defined to be 2 (not 12 as it is defined here) in file Source/WebCore/page/mac/TextIndicatorWindow.mm, <http://trac.webkit.org/browser/trunk/Source/WebCore/page/mac/TextIndicatorWindow.mm?rev=185844#L60>. Is this change in blur radius intentional? Must be a mistake I made long ago (this is why having two copies of the constants is bad!). In any case, the version in TextIndicatorWindow is the "real" one (the one that actually determines... the size of the shadow); this one was just here for this silly rect merging code. Thanks for your very careful review! Comment on attachment 256882 [details] Patch Clearing flags on attachment: 256882 Committed r186890: <http://trac.webkit.org/changeset/186890> All reviewed patches have been landed. Closing bug. |