Bug 146992 – Move indicator rect uniting code to TextIndicatorWindow instead of TextIndicator

• Component: New Bugs
• Status: RESOLVED FIXED

[Tim Horton]

Move indicator rect uniting code to TextIndicatorWindow instead of TextIndicator

[Tim Horton]

Created attachment 256882 [details]
Patch

[Daniel Bates]

Comment on attachment 256882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256882&action=review

> Source/WebCore/page/TextIndicator.cpp:-52
> -const float dropShadowBlurRadius = 12;

Notice that the !ENABLE(LEGACY_TEXT_INDICATOR_STYLE)-variant of the constant dropShadowBlurRadius is defined to be 2 (not 12 as it is defined here) in file Source/WebCore/page/mac/TextIndicatorWindow.mm, <http://trac.webkit.org/browser/trunk/Source/WebCore/page/mac/TextIndicatorWindow.mm?rev=185844#L60>. Is this change in blur radius intentional?

[Tim Horton]

Must be a mistake I made long ago (this is why having two copies of the constants is bad!). In any case, the version in TextIndicatorWindow is the "real" one (the one that actually determines... the size of the shadow); this one was just here for this silly rect merging code. Thanks for your very careful review!

[WebKit Commit Bot]

Comment on attachment 256882 [details]
Patch

Clearing flags on attachment: 256882

Committed r186890: <http://trac.webkit.org/changeset/186890>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.